Skip to content
Snippets Groups Projects

Resolve "Clean some code"

Merged Benoît Harrault requested to merge 10-clean-some-code into master
2 files
+ 49
32
Compare changes
  • Side-by-side
  • Inline
Files
2
+ 5
32
<?php
<?php
require '../spotify/spotify.php';
require '../spotify/spotify.php';
 
require '../spotify/lib.php';
if (isset($_GET['logout'])) {
if (isset($_GET['logout'])) {
$_SESSION['accessToken'] = '';
$_SESSION['accessToken'] = '';
@@ -104,22 +105,8 @@ if ($generatePlaylistFromPlaylist) {
@@ -104,22 +105,8 @@ if ($generatePlaylistFromPlaylist) {
$recommendedTrackIds = $filteredTrackIds;
$recommendedTrackIds = $filteredTrackIds;
}
}
$recommendedTrackIds = array_keys($recommendedTrackIds);
$newPlaylist = createPlaylistWithRandomTracks($api, $recommendedTrackIds);
error_log('=> Got '.count($recommendedTrackIds).' unique recommendatations for this playlist.');
$templateData['infos'][] = getCreatedPlaylistInformationMessage($api, $newPlaylist->id);
shuffle($recommendedTrackIds);
$pickedTrackIds = array_slice($recommendedTrackIds, 0, 50);
error_log('Keep '.count($pickedTrackIds).' tracks.');
$now = new DateTime();
$newPlaylistName = 'Fresh playlist ['.$now->format('Y-m-d H:i:s').']';
error_log('Create new playlist "'.$newPlaylistName.'".');
$newPlaylist = $api->createPlaylist([
'name' => $newPlaylistName,
]);
$api->replacePlaylistTracks($newPlaylist->id, $pickedTrackIds);
$playlistLink = '<a href="'.$newPlaylist->external_urls->spotify.'">'.$newPlaylistName.'</a>';
$templateData['infos'][] = 'Ok created new playlist with '.count($pickedTrackIds).' tracks: '.$playlistLink;
} elseif ($generatePlaylistFromArtists) {
} elseif ($generatePlaylistFromArtists) {
$selectedArtists = $_GET['selected-artist'];
$selectedArtists = $_GET['selected-artist'];
error_log('Will create new playlist with filterted recommendations from artists: '.join(', ', $selectedArtists).'".');
error_log('Will create new playlist with filterted recommendations from artists: '.join(', ', $selectedArtists).'".');
@@ -151,22 +138,8 @@ if ($generatePlaylistFromPlaylist) {
@@ -151,22 +138,8 @@ if ($generatePlaylistFromPlaylist) {
}
}
}
}
$recommendedTrackIds = array_keys($recommendedTrackIds);
$newPlaylist = createPlaylistWithRandomTracks($api, $recommendedTrackIds);
error_log('=> Got '.count($recommendedTrackIds).' unique recommendatations.');
$templateData['infos'][] = getCreatedPlaylistInformationMessage($api, $newPlaylist->id);
shuffle($recommendedTrackIds);
$pickedTrackIds = array_slice($recommendedTrackIds, 0, 50);
error_log('Keep '.count($pickedTrackIds).' random tracks.');
$now = new DateTime();
$newPlaylistName = 'Fresh playlist ['.$now->format('Y-m-d H:i:s').']';
error_log('Create new playlist "'.$newPlaylistName.'".');
$newPlaylist = $api->createPlaylist([
'name' => $newPlaylistName,
]);
$api->replacePlaylistTracks($newPlaylist->id, $pickedTrackIds);
$playlistLink = '<a href="'.$newPlaylist->external_urls->spotify.'">'.$newPlaylistName.'</a>';
$templateData['infos'][] = 'Ok created new playlist with '.count($pickedTrackIds).' tracks: '.$playlistLink;
} else {
} else {
$templateData['topArtists'] = $api->getMyTop('artists', ['limit' => $topArtistsCount, 'time_range' => 'short_term'])->items;
$templateData['topArtists'] = $api->getMyTop('artists', ['limit' => $topArtistsCount, 'time_range' => 'short_term'])->items;
$templateData['playlists'] = $api->getUserPlaylists($user->id, ['limit' => $playlistsCount])->items;
$templateData['playlists'] = $api->getUserPlaylists($user->id, ['limit' => $playlistsCount])->items;
Loading