Merge branch '27-clean-some-code' into 'master'

Resolve "Clean some code"

Closes #27

See merge request !21

.editorconfig

+root = true
+
+[*]
+indent_style = space
+indent_size = 4
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.md]
+trim_trailing_whitespace = false

public/css/styles.css

 @charset "UTF-8";
 
 .spotify-image {
-  display: inline-block;
-  text-align: center;
-  justify-content: center;
-  align-items: center;
-  height: 1rem;
-  width: 1rem;
-  max-height: 1rem;
-  max-width: 1rem;
+    display: inline-block;
+    text-align: center;
+    justify-content: center;
+    align-items: center;
+    height: 1rem;
+    width: 1rem;
+    max-height: 1rem;
+    max-width: 1rem;
 }
 
 .spotify-image>img {
-  border: solid 1px #888;
-  text-align: center;
-  max-height: 1rem;
-  max-width: 1rem;
-  margin: auto;
+    border: solid 1px #888;
+    text-align: center;
+    max-height: 1rem;
+    max-width: 1rem;
+    margin: auto;
 }

public/js/scripts.js

 /* pick some random artists */
 function pickRandomArtists() {
-  var pickedArtistsCount = 6 + Math.floor(Math.random() * 6);
-  var artistElements = document.getElementsByClassName("checkbox-artist");
-  for (var i = 0; i < pickedArtistsCount; i++) {
-    var random = Math.floor(Math.random() * artistElements.length);
-    artistElements[random].click();
-  }
+    var pickedArtistsCount = 6 + Math.floor(Math.random() * 6);
+    var artistElements = document.getElementsByClassName("checkbox-artist");
+    for (var i = 0; i < pickedArtistsCount; i++) {
+        var random = Math.floor(Math.random() * artistElements.length);
+        artistElements[random].click();
+    }
 }

spotify/lib.php

 <?php
 
-function generatePlaylistName() {
-  $now = new DateTime();
-  $name = 'Fresh playlist ['.$now->format('Y-m-d H:i:s').']';
+function generatePlaylistName()
+{
+    $now = new DateTime();
+    $name = 'Fresh playlist ['.$now->format('Y-m-d H:i:s').']';
 
-  return $name;
+    return $name;
 }
 
-function createEmptyPlaylist($api) {
-  $name = generatePlaylistName();
-  error_log('Create new playlist "'.$name.'".');
-  $playlist = $api->createPlaylist([
-      'name' => $name,
-  ]);
+function createEmptyPlaylist($api)
+{
+    $name = generatePlaylistName();
+    error_log('Create new playlist "'.$name.'".');
+    $playlist = $api->createPlaylist([
+        'name' => $name,
+    ]);
 
-  return $playlist;
+    return $playlist;
 }
 
-function pickRandomTrackFromArray($recommendedTrackIds, $count = 50) {
-  $recommendedTrackIds = array_keys($recommendedTrackIds);
-  error_log('=> Got '.count($recommendedTrackIds).' unique recommendatations.');
-  shuffle($recommendedTrackIds);
-  $pickedTrackIds = array_slice($recommendedTrackIds, 0, 50);
-  error_log('Keep '.count($pickedTrackIds).' random tracks.');
+function pickRandomTrackFromArray($recommendedTrackIds, $count = 50)
+{
+    $recommendedTrackIds = array_keys($recommendedTrackIds);
+    error_log('=> Got '.count($recommendedTrackIds).' unique recommendatations.');
+    shuffle($recommendedTrackIds);
+    $pickedTrackIds = array_slice($recommendedTrackIds, 0, 50);
+    error_log('Keep '.count($pickedTrackIds).' random tracks.');
 
-  return $pickedTrackIds;
+    return $pickedTrackIds;
 }
 
-function createPlaylistWithRandomTracks($api, $trackIds, $count = 50) {
-  $playlist = createEmptyPlaylist($api);
-  $pickedTrackIds = pickRandomTrackFromArray($trackIds);
-  $api->replacePlaylistTracks($playlist->id, $pickedTrackIds);
+function createPlaylistWithRandomTracks($api, $trackIds, $count = 50)
+{
+    $playlist = createEmptyPlaylist($api);
+    $pickedTrackIds = pickRandomTrackFromArray($trackIds);
+    $api->replacePlaylistTracks($playlist->id, $pickedTrackIds);
 
-  return $api->getPlaylist($playlist->id);
+    return $api->getPlaylist($playlist->id);
 }
 
-function getCreatedPlaylistInformationMessage($api, $playlist) {
-  $link = '<a href="'.$playlist->external_urls->spotify.'">'.$playlist->name.'</a>';
-  $message = 'Ok created new playlist with '.count($playlist->tracks->items).' tracks: '.$link;
+function getCreatedPlaylistInformationMessage($api, $playlist)
+{
+    $link = '<a href="'.$playlist->external_urls->spotify.'">'.$playlist->name.'</a>';
+    $message = 'Ok created new playlist with '.count($playlist->tracks->items).' tracks: '.$link;
 
-  return $message;
+    return $message;
 }
 
-function createDisplayablePlaylist($playlist) {
-  $output = [
-    'id' => $playlist->id,
-    'name' => $playlist->name,
-    'tracks' => [],
-    'artists' => [],
-  ];
-
-  $artists = [];
-
-  foreach($playlist->tracks->items as $item) {
-    $track = [
-      'id' => $item->track->id,
-      'name' => $item->track->name,
-      'artists' => [],
+function createDisplayablePlaylist($playlist)
+{
+    $output = [
+        'id' => $playlist->id,
+        'name' => $playlist->name,
+        'tracks' => [],
+        'artists' => [],
     ];
 
-    foreach($item->track->artists as $artist) {
-      $track['artists'][] = [
-        'id' => $artist->id,
-        'name' => $artist->name,
-      ];
-      $artists[$artist->id] = $artist->name;
-    }
+    $artists = [];
+
+    foreach ($playlist->tracks->items as $item) {
+        $track = [
+            'id' => $item->track->id,
+            'name' => $item->track->name,
+            'artists' => [],
+        ];
 
-    $output['tracks'][] = $track;
-  }
+        foreach ($item->track->artists as $artist) {
+            $track['artists'][] = [
+                'id' => $artist->id,
+                'name' => $artist->name,
+            ];
+            $artists[$artist->id] = $artist->name;
+        }
+
+        $output['tracks'][] = $track;
+    }
 
-  $output['artists'] = array_values($artists);
+    $output['artists'] = array_values($artists);
 
-  return $output;
+    return $output;
 }

spotify/spotify.php

@@ -5,7 +5,7 @@ require '../vendor/autoload.php';
 
 $parametersFile = realpath(__DIR__.'/../parameters.php');
 if (!is_file($parametersFile)) {
-  die('Missing parameters file: '.$parametersFile);
+    die('Missing parameters file: '.$parametersFile);
 }
 
 require $parametersFile;