Skip to content
Snippets Groups Projects
Commit 0b4008f8 authored by Benoît Harrault's avatar Benoît Harrault
Browse files

Avoid print calls in production code

parent 6219fdb0
No related branches found
No related tags found
1 merge request!58Resolve "Avoid print calls in production code"
Pipeline #5256 passed
org.gradle.jvmargs=-Xmx1536M org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true android.useAndroidX=true
android.enableJetifier=true android.enableJetifier=true
app.versionName=1.0.48 app.versionName=1.0.49
app.versionCode=49 app.versionCode=50
...@@ -4,6 +4,7 @@ import 'package:hydrated_bloc/hydrated_bloc.dart'; ...@@ -4,6 +4,7 @@ import 'package:hydrated_bloc/hydrated_bloc.dart';
import 'package:random/models/api_failure.dart'; import 'package:random/models/api_failure.dart';
import 'package:random/models/api_data.dart'; import 'package:random/models/api_data.dart';
import 'package:random/repository/api.dart'; import 'package:random/repository/api.dart';
import 'package:random/utils/tools.dart';
part 'api_state.dart'; part 'api_state.dart';
...@@ -27,7 +28,7 @@ class ApiDataCubit extends HydratedCubit<ApiDataState> { ...@@ -27,7 +28,7 @@ class ApiDataCubit extends HydratedCubit<ApiDataState> {
} }
} }
} }
print('emit new state: $stateAsString'); printlog('emit new state: $stateAsString');
emit(state); emit(state);
} }
...@@ -41,7 +42,7 @@ class ApiDataCubit extends HydratedCubit<ApiDataState> { ...@@ -41,7 +42,7 @@ class ApiDataCubit extends HydratedCubit<ApiDataState> {
} on ApiFailure catch (err) { } on ApiFailure catch (err) {
customEmit(ApiDataFetchError(failure: err)); customEmit(ApiDataFetchError(failure: err));
} catch (err) { } catch (err) {
print("Error (fetchApiData): $err"); printlog("Error (fetchApiData): $err");
} }
return ApiData.fromJson({}); return ApiData.fromJson({});
} }
......
...@@ -16,15 +16,12 @@ class ApiDataFetchInitial extends ApiDataState {} ...@@ -16,15 +16,12 @@ class ApiDataFetchInitial extends ApiDataState {}
class ApiDataFetchLoading extends ApiDataState {} class ApiDataFetchLoading extends ApiDataState {}
class ApiDataFetchLoaded extends ApiDataState { class ApiDataFetchLoaded extends ApiDataState {
@override
final ApiData data;
const ApiDataFetchLoaded({ const ApiDataFetchLoaded({
required this.data, required super.data,
}); });
@override @override
List<Object> get props => [data]; List<Object> get props => [data!];
} }
class ApiDataFetchError extends ApiDataState { class ApiDataFetchError extends ApiDataState {
......
...@@ -3,6 +3,7 @@ import 'dart:math'; ...@@ -3,6 +3,7 @@ import 'dart:math';
import 'package:random/models/game/game_board.dart'; import 'package:random/models/game/game_board.dart';
import 'package:random/models/game/game_cell.dart'; import 'package:random/models/game/game_cell.dart';
import 'package:random/models/game/game_settings.dart'; import 'package:random/models/game/game_settings.dart';
import 'package:random/utils/tools.dart';
class Game { class Game {
GameBoard board; GameBoard board;
...@@ -88,7 +89,7 @@ class Game { ...@@ -88,7 +89,7 @@ class Game {
void dump() { void dump() {
GameBoard.printGrid(board.cells); GameBoard.printGrid(board.cells);
print(settings.toJson()); printlog(settings.toString());
print(toJson()); printlog(toString());
} }
} }
...@@ -2,6 +2,7 @@ import 'dart:math'; ...@@ -2,6 +2,7 @@ import 'dart:math';
import 'package:random/models/game/game_cell.dart'; import 'package:random/models/game/game_cell.dart';
import 'package:random/models/game/game_settings.dart'; import 'package:random/models/game/game_settings.dart';
import 'package:random/utils/tools.dart';
class GameBoard { class GameBoard {
final List<List<GameCell>> cells; final List<List<GameCell>> cells;
...@@ -36,17 +37,17 @@ class GameBoard { ...@@ -36,17 +37,17 @@ class GameBoard {
} }
static printGrid(List<List<GameCell>> cells) { static printGrid(List<List<GameCell>> cells) {
print(''); printlog('');
print('-------'); printlog('-------');
for (var rowIndex = 0; rowIndex < cells.length; rowIndex++) { for (var rowIndex = 0; rowIndex < cells.length; rowIndex++) {
String row = ''; String row = '';
for (var colIndex = 0; colIndex < cells[rowIndex].length; colIndex++) { for (var colIndex = 0; colIndex < cells[rowIndex].length; colIndex++) {
row += cells[rowIndex][colIndex].value.toString(); row += cells[rowIndex][colIndex].value.toString();
} }
print(row); printlog(row);
} }
print('-------'); printlog('-------');
print(''); printlog('');
} }
@override @override
......
...@@ -3,6 +3,7 @@ import 'dart:io'; ...@@ -3,6 +3,7 @@ import 'dart:io';
import 'package:dio/dio.dart'; import 'package:dio/dio.dart';
import 'package:random/models/api_failure.dart'; import 'package:random/models/api_failure.dart';
import 'package:random/utils/tools.dart';
class ApiService { class ApiService {
final Dio _dio = Dio(); final Dio _dio = Dio();
...@@ -12,15 +13,15 @@ class ApiService { ...@@ -12,15 +13,15 @@ class ApiService {
Future<Response?> getData() async { Future<Response?> getData() async {
String url = '$baseUrl/get.php'; String url = '$baseUrl/get.php';
try { try {
print('fetching api data... $url'); printlog('fetching api data... $url');
final Response response = await _dio.get(url); final Response response = await _dio.get(url);
print('ok got api response.'); printlog('ok got api response.');
print(response); printlog(response.toString());
return response; return response;
} on SocketException { } on SocketException {
throw const ApiFailure(message: 'Failed to reach API endpoint.'); throw const ApiFailure(message: 'Failed to reach API endpoint.');
} catch (err) { } catch (err) {
print("Error (getData): $err"); printlog("Error (getData): $err");
throw ApiFailure(message: "$err"); throw ApiFailure(message: "$err");
} }
} }
......
import 'package:random/models/api_data.dart'; import 'package:random/models/api_data.dart';
import 'package:random/network/api.dart'; import 'package:random/network/api.dart';
import 'package:random/utils/tools.dart';
class ApiRepository { class ApiRepository {
const ApiRepository({required this.apiService}); const ApiRepository({required this.apiService});
...@@ -7,15 +8,15 @@ class ApiRepository { ...@@ -7,15 +8,15 @@ class ApiRepository {
final ApiService apiService; final ApiService apiService;
Future<ApiData> getApiData() async { Future<ApiData> getApiData() async {
print('(getApiData) delayed API call...'); printlog('(getApiData) delayed API call...');
final response = await Future.delayed(const Duration(milliseconds: 1000)) final response = await Future.delayed(const Duration(milliseconds: 1000))
.then((value) => apiService.getData()); .then((value) => apiService.getData());
if (response != null) { if (response != null) {
print('(getApiData) got api response'); printlog('(getApiData) got api response');
print(response.data); printlog(response.data);
return ApiData.fromJson(response.data); return ApiData.fromJson(response.data);
} }
print('(getApiData) failed'); printlog('(getApiData) failed');
return ApiData.fromJson({}); return ApiData.fromJson({});
} }
} }
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:random/ui/painters/graph_painter.dart'; import 'package:random/ui/painters/graph_painter.dart';
import 'package:random/utils/tools.dart';
class GraphPage extends StatefulWidget { class GraphPage extends StatefulWidget {
const GraphPage({super.key}); const GraphPage({super.key});
...@@ -33,7 +34,7 @@ class _GraphPageState extends State<GraphPage> { ...@@ -33,7 +34,7 @@ class _GraphPageState extends State<GraphPage> {
onTapUp: (details) { onTapUp: (details) {
double xTap = details.localPosition.dx; double xTap = details.localPosition.dx;
double yTap = details.localPosition.dy; double yTap = details.localPosition.dy;
print('[$xTap,$yTap]'); printlog('[$xTap,$yTap]');
}, },
child: Container( child: Container(
margin: const EdgeInsets.all(4), margin: const EdgeInsets.all(4),
......
...@@ -6,6 +6,7 @@ import 'package:random/models/game/game.dart'; ...@@ -6,6 +6,7 @@ import 'package:random/models/game/game.dart';
import 'package:random/models/game/game_settings.dart'; import 'package:random/models/game/game_settings.dart';
import 'package:random/ui/painters/cell_painter.dart'; import 'package:random/ui/painters/cell_painter.dart';
import 'package:random/ui/widgets/game/game_score.dart'; import 'package:random/ui/widgets/game/game_score.dart';
import 'package:random/utils/tools.dart';
class GameBoardWidget extends StatefulWidget { class GameBoardWidget extends StatefulWidget {
const GameBoardWidget({ const GameBoardWidget({
...@@ -168,11 +169,11 @@ class _GameBoardWidget extends State<GameBoardWidget> with TickerProviderStateMi ...@@ -168,11 +169,11 @@ class _GameBoardWidget extends State<GameBoardWidget> with TickerProviderStateMi
int x = (xTap / widgetWidth * columnsCount).toInt(); int x = (xTap / widgetWidth * columnsCount).toInt();
int y = (yTap / widgetHeight * rowsCount).toInt(); int y = (yTap / widgetHeight * rowsCount).toInt();
print('[$x,$y]'); printlog('[$x,$y]');
removeCell(context, x, y); removeCell(context, x, y);
} else { } else {
print('animation in progress...'); printlog('animation in progress...');
} }
}, },
); );
......
...@@ -5,6 +5,7 @@ import 'package:flutter/material.dart'; ...@@ -5,6 +5,7 @@ import 'package:flutter/material.dart';
import 'package:unicons/unicons.dart'; import 'package:unicons/unicons.dart';
import 'package:random/utils/picture_storage.dart'; import 'package:random/utils/picture_storage.dart';
import 'package:random/utils/tools.dart';
class TakePictureWidget extends StatefulWidget { class TakePictureWidget extends StatefulWidget {
const TakePictureWidget({super.key}); const TakePictureWidget({super.key});
...@@ -41,7 +42,7 @@ class TakePictureWidgetState extends State<TakePictureWidget> { ...@@ -41,7 +42,7 @@ class TakePictureWidgetState extends State<TakePictureWidget> {
} }
setState(() {}); setState(() {});
}); });
} }
@override @override
void dispose() { void dispose() {
...@@ -71,14 +72,14 @@ class TakePictureWidgetState extends State<TakePictureWidget> { ...@@ -71,14 +72,14 @@ class TakePictureWidgetState extends State<TakePictureWidget> {
try { try {
if ((controller != null) && (controller!.value.isInitialized)) { if ((controller != null) && (controller!.value.isInitialized)) {
final XFile image = await controller!.takePicture(); final XFile image = await controller!.takePicture();
print('image.path: ${image.path}'); printlog('image.path: ${image.path}');
debug.add('image.path: ${image.path}'); debug.add('image.path: ${image.path}');
File savedFile = await storage!.writeCounter(File(image.path)); File savedFile = await storage!.writeCounter(File(image.path));
debug.add('image.path: ${image.path}'); debug.add('image.path: ${image.path}');
String imagePath = savedFile.path; String imagePath = savedFile.path;
print('imagePath: $imagePath'); printlog('imagePath: $imagePath');
debug.add('imagePath: $imagePath'); debug.add('imagePath: $imagePath');
previousImages.add(imagePath); previousImages.add(imagePath);
...@@ -88,7 +89,7 @@ class TakePictureWidgetState extends State<TakePictureWidget> { ...@@ -88,7 +89,7 @@ class TakePictureWidgetState extends State<TakePictureWidget> {
debug.add('error: $e'); debug.add('error: $e');
setState(() {}); setState(() {});
print(e); printlog(e.toString());
} }
}, },
), ),
......
...@@ -3,6 +3,8 @@ import 'dart:io'; ...@@ -3,6 +3,8 @@ import 'dart:io';
import 'package:path/path.dart'; import 'package:path/path.dart';
import 'package:path_provider/path_provider.dart'; import 'package:path_provider/path_provider.dart';
import 'package:random/utils/tools.dart';
class PictureStorage { class PictureStorage {
Future<String> get _localPath async { Future<String> get _localPath async {
final directory = await getApplicationDocumentsDirectory(); final directory = await getApplicationDocumentsDirectory();
...@@ -20,7 +22,7 @@ class PictureStorage { ...@@ -20,7 +22,7 @@ class PictureStorage {
try { try {
return await sourceFile.rename(newPath); return await sourceFile.rename(newPath);
} on FileSystemException catch (e) { } on FileSystemException catch (e) {
print('Found exception while moving file: $e'); printlog('Found exception while moving file: $e');
final newFile = await sourceFile.copy(newPath); final newFile = await sourceFile.copy(newPath);
await sourceFile.delete(); await sourceFile.delete();
return newFile; return newFile;
......
import 'package:flutter/foundation.dart';
void printlog(String message) {
if (!kReleaseMode) {
debugPrint(message);
}
}
...@@ -53,10 +53,10 @@ packages: ...@@ -53,10 +53,10 @@ packages:
dependency: transitive dependency: transitive
description: description:
name: camera_platform_interface name: camera_platform_interface
sha256: fceb2c36038b6392317b1d5790c6ba9e6ca9f1da3031181b8bea03882bf9387a sha256: a250314a48ea337b35909a4c9d5416a208d736dcb01d0b02c6af122be66660b0
url: "https://pub.dev" url: "https://pub.dev"
source: hosted source: hosted
version: "2.7.3" version: "2.7.4"
camera_web: camera_web:
dependency: transitive dependency: transitive
description: description:
...@@ -364,10 +364,10 @@ packages: ...@@ -364,10 +364,10 @@ packages:
dependency: transitive dependency: transitive
description: description:
name: provider name: provider
sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev" url: "https://pub.dev"
source: hosted source: hosted
version: "6.1.1" version: "6.1.2"
shared_preferences: shared_preferences:
dependency: transitive dependency: transitive
description: description:
......
...@@ -3,7 +3,7 @@ description: A random application, for testing purpose only. ...@@ -3,7 +3,7 @@ description: A random application, for testing purpose only.
publish_to: 'none' publish_to: 'none'
version: 1.0.48+49 version: 1.0.49+50
environment: environment:
sdk: '^3.0.0' sdk: '^3.0.0'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment