Skip to content
Snippets Groups Projects
Commit e1d64654 authored by Benoît Harrault's avatar Benoît Harrault
Browse files

Merge branch '32-fix-improve-charts-display' into 'master'

Resolve "Fix/improve charts display"

Closes #32

See merge request !29
parents ca6682c3 685da11f
Branches
Tags Release_0.0.26_26
1 merge request!29Resolve "Fix/improve charts display"
Pipeline #4579 passed
org.gradle.jvmargs=-Xmx1536M org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true android.useAndroidX=true
android.enableJetifier=true android.enableJetifier=true
app.versionName=0.0.25 app.versionName=0.0.26
app.versionCode=25 app.versionCode=26
Fix/improve charts display.
Améliorations visuelles des graphiques.
...@@ -11,9 +11,6 @@ class ChartDiscoveries extends CustomBarChart { ...@@ -11,9 +11,6 @@ class ChartDiscoveries extends CustomBarChart {
ChartDiscoveries({super.key, required this.chartData}); ChartDiscoveries({super.key, required this.chartData});
final double chartHeight = 120.0;
final double verticalTicksInterval = 10;
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
return Container( return Container(
......
...@@ -10,7 +10,6 @@ class ChartTimelineCounts extends CustomBarChart { ...@@ -10,7 +10,6 @@ class ChartTimelineCounts extends CustomBarChart {
ChartTimelineCounts({super.key, required this.chartData}); ChartTimelineCounts({super.key, required this.chartData});
final double chartHeight = 120.0;
final double verticalTicksInterval = 50; final double verticalTicksInterval = 50;
@override @override
......
...@@ -22,7 +22,7 @@ class ChartTopArtists extends StatelessWidget { ...@@ -22,7 +22,7 @@ class ChartTopArtists extends StatelessWidget {
child: PieChart( child: PieChart(
PieChartData( PieChartData(
sections: getPieChartData(), sections: getPieChartData(),
sectionsSpace: 1, sectionsSpace: 2,
centerSpaceRadius: 40, centerSpaceRadius: 40,
startDegreeOffset: -45, startDegreeOffset: -45,
pieTouchData: PieTouchData(enabled: false), pieTouchData: PieTouchData(enabled: false),
...@@ -53,7 +53,7 @@ class ChartTopArtists extends StatelessWidget { ...@@ -53,7 +53,7 @@ class ChartTopArtists extends StatelessWidget {
0xffed6f, 0xffed6f,
]; ];
return Color(hexValues[index] + 0xff000000); return Color(hexValues[index % hexValues.length] + 0xff000000);
} }
List<PieChartSectionData> getPieChartData() { List<PieChartSectionData> getPieChartData() {
...@@ -66,17 +66,25 @@ class ChartTopArtists extends StatelessWidget { ...@@ -66,17 +66,25 @@ class ChartTopArtists extends StatelessWidget {
int index = 0; int index = 0;
this.chartData.topArtists.forEach((element) { this.chartData.topArtists.forEach((element) {
items.add(PieChartSectionData( Color baseColor = getColorIndex(index++);
final PieChartSectionData item = PieChartSectionData(
value: element.count.toDouble(), value: element.count.toDouble(),
title: element.artistName, title: element.artistName,
color: getColorIndex(index++).darken(20), color: baseColor.darken(20),
borderSide: BorderSide(
color: baseColor.darken(40),
width: 1,
),
radius: radius, radius: radius,
titleStyle: TextStyle( titleStyle: TextStyle(
fontSize: fontSize, fontSize: fontSize,
color: AppColors.mainTextColor1, color: AppColors.mainTextColor1,
shadows: shadows, shadows: shadows,
), ),
)); );
items.add(item);
}); });
return items; return items;
...@@ -89,14 +97,20 @@ class ChartTopArtists extends StatelessWidget { ...@@ -89,14 +97,20 @@ class ChartTopArtists extends StatelessWidget {
int index = 0; int index = 0;
this.chartData.topArtists.forEach((element) { this.chartData.topArtists.forEach((element) {
items.add(Row( Color baseColor = getColorIndex(index++);
final Widget item = Row(
children: <Widget>[ children: <Widget>[
Container( Container(
width: itemSize, width: itemSize,
height: itemSize, height: itemSize,
decoration: BoxDecoration( decoration: BoxDecoration(
shape: BoxShape.rectangle, shape: BoxShape.rectangle,
color: getColorIndex(index++).darken(20), color: baseColor.darken(20),
border: Border.all(
color: baseColor.darken(40),
width: 1,
),
), ),
), ),
const SizedBox( const SizedBox(
...@@ -110,7 +124,9 @@ class ChartTopArtists extends StatelessWidget { ...@@ -110,7 +124,9 @@ class ChartTopArtists extends StatelessWidget {
), ),
) )
], ],
)); );
items.add(item);
}); });
return Column( return Column(
......
...@@ -3,7 +3,7 @@ description: Display scrobbles data and charts ...@@ -3,7 +3,7 @@ description: Display scrobbles data and charts
publish_to: 'none' publish_to: 'none'
version: 0.0.25+25 version: 0.0.26+26
environment: environment:
sdk: '^3.0.0' sdk: '^3.0.0'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment