Skip to content
Snippets Groups Projects
Commit d9ae6ad2 authored by Benoît Harrault's avatar Benoît Harrault
Browse files

Merge branch '16-avoid-print-calls-in-production-code' into 'master'

Resolve "Avoid print calls in production code"

Closes #16

See merge request !16
parents badc0db3 ec0d2824
No related branches found
No related tags found
1 merge request!16Resolve "Avoid print calls in production code"
Pipeline #5346 canceled
org.gradle.jvmargs=-Xmx1536M org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true android.useAndroidX=true
android.enableJetifier=true android.enableJetifier=true
app.versionName=0.0.14 app.versionName=0.0.15
app.versionCode=14 app.versionCode=15
Avoid print calls in production code.
Supprime les appels à print dans le code de production.
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
import 'package:shared_preferences/shared_preferences.dart'; import 'package:shared_preferences/shared_preferences.dart';
import 'package:plotter/utils/tools.dart';
class Data extends ChangeNotifier { class Data extends ChangeNotifier {
// Application settings // Application settings
String _apiHost = ''; String _apiHost = '';
...@@ -20,7 +22,7 @@ class Data extends ChangeNotifier { ...@@ -20,7 +22,7 @@ class Data extends ChangeNotifier {
} }
setParameterValue(String parameterCode, String parameterValue) async { setParameterValue(String parameterCode, String parameterValue) async {
print('set parameter "$parameterCode" to value "$parameterValue"'); printlog('set parameter "$parameterCode" to value "$parameterValue"');
switch (parameterCode) { switch (parameterCode) {
case 'apiHost': case 'apiHost':
{ {
...@@ -45,7 +47,7 @@ class Data extends ChangeNotifier { ...@@ -45,7 +47,7 @@ class Data extends ChangeNotifier {
String get apiStatus => _apiStatus; String get apiStatus => _apiStatus;
void updateApiStatus(String apiStatus) { void updateApiStatus(String apiStatus) {
print('new API status: $apiStatus'); printlog('new API status: $apiStatus');
_apiStatus = apiStatus; _apiStatus = apiStatus;
notifyListeners(); notifyListeners();
} }
......
import 'package:flutter/foundation.dart';
void printlog(String message) {
if (!kReleaseMode) {
debugPrint(message);
}
}
...@@ -159,10 +159,10 @@ packages: ...@@ -159,10 +159,10 @@ packages:
dependency: "direct main" dependency: "direct main"
description: description:
name: provider name: provider
sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev" url: "https://pub.dev"
source: hosted source: hosted
version: "6.1.1" version: "6.1.2"
shared_preferences: shared_preferences:
dependency: "direct main" dependency: "direct main"
description: description:
......
name: plotter name: plotter
description: A plotter helper application. description: A plotter helper application.
publish_to: 'none' publish_to: 'none'
version: 0.0.14+14 version: 0.0.15+15
environment: environment:
sdk: '^3.0.0' sdk: '^3.0.0'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment