Skip to content
Snippets Groups Projects
Commit 4dcb677a authored by Benoît Harrault's avatar Benoît Harrault
Browse files

Avoid print calls in production code

parent 9167bee6
No related branches found
No related tags found
1 merge request!31Resolve "Avoid print calls in production code"
Pipeline #5250 passed
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
app.versionName=0.0.27
app.versionCode=27
app.versionName=0.0.28
app.versionCode=28
Avoid print calls in production code.
Supprime les appels à print dans le code de production.
import 'package:flutter/material.dart';
import '../provider/data.dart';
import '../utils/game_utils.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/game_utils.dart';
class Board {
static Container buildGameBoard(Data myProvider) {
......
import 'package:flutter/material.dart';
import '../layout/board.dart';
import '../layout/keyboard.dart';
import '../provider/data.dart';
import '../utils/game_utils.dart';
import 'package:momomotus/layout/board.dart';
import 'package:momomotus/layout/keyboard.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/game_utils.dart';
class Game {
static Widget buildGameWidget(Data myProvider) {
......
import 'package:flutter/material.dart';
import '../provider/data.dart';
import '../utils/game_utils.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/game_utils.dart';
class Keyboard {
static Container buildWidget(Data myProvider) {
......
import 'package:flutter/material.dart';
import '../provider/data.dart';
import '../utils/game_utils.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/game_utils.dart';
class Parameters {
static Container buildParametersSelector(Data myProvider) {
......
......@@ -3,8 +3,8 @@ import 'package:flutter/services.dart';
import 'package:provider/provider.dart';
import 'package:overlay_support/overlay_support.dart';
import 'provider/data.dart';
import 'screens/home.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/screens/home.dart';
void main() {
WidgetsFlutterBinding.ensureInitialized();
......
import 'package:flutter/foundation.dart';
import 'package:shared_preferences/shared_preferences.dart';
import 'package:momomotus/utils/tools.dart';
class Data extends ChangeNotifier {
// Configuration available values
final List _availableLangValues = ['fr'];
......@@ -78,7 +80,7 @@ class Data extends ChangeNotifier {
void currentGuessSubmitWord() {
if (_currentGuess.length == int.parse(_length)) {
if (_currentGuess == _word) {
print('Word found!');
printlog('Word found!');
_foundWord = true;
}
addGuess(_currentGuess);
......
......@@ -2,10 +2,10 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart';
import 'package:overlay_support/overlay_support.dart';
import '../layout/game.dart';
import '../layout/parameters.dart';
import '../provider/data.dart';
import '../utils/game_utils.dart';
import 'package:momomotus/layout/game.dart';
import 'package:momomotus/layout/parameters.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/game_utils.dart';
class Home extends StatefulWidget {
static const String id = 'home';
......
import '../provider/data.dart';
import '../utils/random_pick_word.dart';
import 'package:momomotus/provider/data.dart';
import 'package:momomotus/utils/random_pick_word.dart';
import 'package:momomotus/utils/tools.dart';
class GameUtils {
static Future<void> quitGame(Data myProvider) async {
......@@ -7,7 +8,8 @@ class GameUtils {
}
static Future<void> startGame(Data myProvider) async {
print('Starting game (${myProvider.lang} / ${myProvider.length} / ${myProvider.level} )');
printlog(
'Starting game (${myProvider.lang} / ${myProvider.length} / ${myProvider.level} )');
myProvider.resetGame();
......@@ -36,7 +38,7 @@ class GameUtils {
}
} while (myProvider.word != word && attempts < 10);
print('Picked word: $word');
printlog('Picked word: $word');
}
static void addLetter(Data myProvider, String letter) {
......@@ -89,10 +91,10 @@ class GameUtils {
static void submitWord(Data myProvider) {
if (GameUtils.checkCurrentlyGuessedWordExists(myProvider)) {
print('Ok word allowed: "${myProvider.currentGuess}".');
printlog('Ok word allowed: "${myProvider.currentGuess}".');
myProvider.currentGuessSubmitWord();
} else {
print('Unknown word: "${myProvider.currentGuess}".');
printlog('Unknown word: "${myProvider.currentGuess}".');
myProvider.currentGuessSubmitWrongWord();
}
}
......
......@@ -4,6 +4,8 @@ import "dart:math";
import 'package:flutter/services.dart';
import 'package:momomotus/utils/tools.dart';
class RandomPickWord {
static Set<String> wordList = <String>{};
static Set<String> dictionary = <String>{};
......@@ -33,7 +35,7 @@ class RandomPickWord {
String wordBaseFilename = 'words-$length-$lang';
// Get full dictionary (eligible words)
print('Reload dictionary ($lang / $length)');
printlog('Reload dictionary ($lang / $length)');
try {
String wordsFile = '$wordBaseFilename-dictionary';
var data = await rootBundle.loadString('assets/files/$wordsFile.txt');
......@@ -47,7 +49,7 @@ class RandomPickWord {
}
// Get guessable words list (will pick random word from)
print('Reload words list ($lang / $length / $level)');
printlog('Reload words list ($lang / $length / $level)');
try {
String wordsFile = '$wordBaseFilename-$level';
var data = await rootBundle.loadString('assets/files/$wordsFile.txt');
......@@ -61,8 +63,8 @@ class RandomPickWord {
}
}
print('Words in dictionary: ${dictionary.length}');
print('Words in words list: ${wordList.length}');
printlog('Words in dictionary: ${dictionary.length}');
printlog('Words in words list: ${wordList.length}');
_word = '';
await wordFromLocalFile();
......@@ -71,7 +73,7 @@ class RandomPickWord {
Future<void> wordFromLocalFile() async {
// Check we have enough words
if (wordList.isEmpty) {
print('Not enough words in list.');
printlog('Not enough words in list.');
_word = '';
} else {
final random = Random();
......
import 'package:flutter/foundation.dart';
void printlog(String message) {
if (!kReleaseMode) {
debugPrint(message);
}
}
......@@ -151,10 +151,10 @@ packages:
dependency: "direct main"
description:
name: provider
sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096"
sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev"
source: hosted
version: "6.1.1"
version: "6.1.2"
shared_preferences:
dependency: "direct main"
description:
......
name: momomotus
description: A motus-like game application.
publish_to: 'none'
version: 0.0.27+27
version: 0.0.28+28
environment:
sdk: '^3.0.0'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment