Skip to content
Snippets Groups Projects
Commit b0681b66 authored by Benoît Harrault's avatar Benoît Harrault
Browse files

Avoid print calls in production code

parent 9948bb1c
No related branches found
No related tags found
1 merge request!30Resolve "Avoid print calls in production code"
Pipeline #5251 passed
This commit is part of merge request !30. Comments created here will be created in the context of that merge request.
Showing
with 63 additions and 41 deletions
org.gradle.jvmargs=-Xmx1536M org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true android.useAndroidX=true
android.enableJetifier=true android.enableJetifier=true
app.versionName=0.0.26 app.versionName=0.0.27
app.versionCode=26 app.versionCode=27
Avoid print calls in production code.
Supprime les appels à print dans le code de production.
import 'package:jeweled/utils/tools.dart';
class DefaultGameSettings { class DefaultGameSettings {
static const List<String> availableParameters = [ static const List<String> availableParameters = [
'boardSize', 'boardSize',
...@@ -38,7 +40,7 @@ class DefaultGameSettings { ...@@ -38,7 +40,7 @@ class DefaultGameSettings {
return DefaultGameSettings.allowedColorsCountValues; return DefaultGameSettings.allowedColorsCountValues;
} }
print('Did not find any available value for game parameter "$parameterCode".'); printlog('Did not find any available value for game parameter "$parameterCode".');
return []; return [];
} }
......
import 'package:jeweled/utils/tools.dart';
class DefaultGlobalSettings { class DefaultGlobalSettings {
static const List<String> availableParameters = [ static const List<String> availableParameters = [
'colorsTheme', 'colorsTheme',
...@@ -60,7 +62,7 @@ class DefaultGlobalSettings { ...@@ -60,7 +62,7 @@ class DefaultGlobalSettings {
return DefaultGlobalSettings.allowedGraphicThemeValues; return DefaultGlobalSettings.allowedGraphicThemeValues;
} }
print('Did not find any available value for global parameter "$parameterCode".'); printlog('Did not find any available value for global parameter "$parameterCode".');
return []; return [];
} }
} }
...@@ -7,6 +7,7 @@ import 'package:jeweled/models/game.dart'; ...@@ -7,6 +7,7 @@ import 'package:jeweled/models/game.dart';
import 'package:jeweled/models/cell_location.dart'; import 'package:jeweled/models/cell_location.dart';
import 'package:jeweled/models/settings_game.dart'; import 'package:jeweled/models/settings_game.dart';
import 'package:jeweled/models/settings_global.dart'; import 'package:jeweled/models/settings_global.dart';
import 'package:jeweled/utils/tools.dart';
part 'game_state.dart'; part 'game_state.dart';
...@@ -133,7 +134,7 @@ class GameCubit extends HydratedCubit<GameState> { ...@@ -133,7 +134,7 @@ class GameCubit extends HydratedCubit<GameState> {
refresh(); refresh();
if (!state.currentGame.hasAtLeastOneAvailableBlock()) { if (!state.currentGame.hasAtLeastOneAvailableBlock()) {
print('no more block found. finish game.'); printlog('no more block found. finish game.');
updateGameIsFinished(true); updateGameIsFinished(true);
} }
} }
......
...@@ -3,6 +3,7 @@ import 'package:flutter/material.dart'; ...@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
import 'package:hydrated_bloc/hydrated_bloc.dart'; import 'package:hydrated_bloc/hydrated_bloc.dart';
import 'package:jeweled/models/settings_game.dart'; import 'package:jeweled/models/settings_game.dart';
import 'package:jeweled/utils/tools.dart';
part 'settings_game_state.dart'; part 'settings_game_state.dart';
...@@ -34,8 +35,8 @@ class GameSettingsCubit extends HydratedCubit<GameSettingsState> { ...@@ -34,8 +35,8 @@ class GameSettingsCubit extends HydratedCubit<GameSettingsState> {
} }
void setParameterValue(String code, int value) { void setParameterValue(String code, int value) {
print('GameSettingsCubit.setParameterValue'); printlog('GameSettingsCubit.setParameterValue');
print('code: $code / value: $value'); printlog('code: $code / value: $value');
int boardSize = code == 'boardSize' ? value : getParameterValue('boardSize'); int boardSize = code == 'boardSize' ? value : getParameterValue('boardSize');
int colorsCount = code == 'colorsCount' ? value : getParameterValue('colorsCount'); int colorsCount = code == 'colorsCount' ? value : getParameterValue('colorsCount');
......
...@@ -3,6 +3,7 @@ import 'package:flutter/material.dart'; ...@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
import 'package:hydrated_bloc/hydrated_bloc.dart'; import 'package:hydrated_bloc/hydrated_bloc.dart';
import 'package:jeweled/models/settings_global.dart'; import 'package:jeweled/models/settings_global.dart';
import 'package:jeweled/utils/tools.dart';
part 'settings_global_state.dart'; part 'settings_global_state.dart';
...@@ -34,8 +35,8 @@ class GlobalSettingsCubit extends HydratedCubit<GlobalSettingsState> { ...@@ -34,8 +35,8 @@ class GlobalSettingsCubit extends HydratedCubit<GlobalSettingsState> {
} }
void setParameterValue(String code, int value) { void setParameterValue(String code, int value) {
print('GlobalSettingsCubit.setParameterValue'); printlog('GlobalSettingsCubit.setParameterValue');
print('code: $code / value: $value'); printlog('code: $code / value: $value');
int colorsTheme = code == 'colorsTheme' ? value : getParameterValue('colorsTheme'); int colorsTheme = code == 'colorsTheme' ? value : getParameterValue('colorsTheme');
int graphicTheme = code == 'graphicTheme' ? value : getParameterValue('graphicTheme'); int graphicTheme = code == 'graphicTheme' ? value : getParameterValue('graphicTheme');
......
...@@ -7,6 +7,7 @@ import 'package:jeweled/models/cell_location.dart'; ...@@ -7,6 +7,7 @@ import 'package:jeweled/models/cell_location.dart';
import 'package:jeweled/models/settings_game.dart'; import 'package:jeweled/models/settings_game.dart';
import 'package:jeweled/models/settings_global.dart'; import 'package:jeweled/models/settings_global.dart';
import 'package:jeweled/utils/color_theme.dart'; import 'package:jeweled/utils/color_theme.dart';
import 'package:jeweled/utils/tools.dart';
class Game { class Game {
final GameBoard board; final GameBoard board;
...@@ -195,7 +196,7 @@ class Game { ...@@ -195,7 +196,7 @@ class Game {
} }
} }
print('Board is locked!'); printlog('Board is locked!');
return false; return false;
} }
...@@ -269,22 +270,22 @@ class Game { ...@@ -269,22 +270,22 @@ class Game {
} }
void dump() { void dump() {
print(''); printlog('');
print('## Current game dump:'); printlog('## Current game dump:');
print(''); printlog('');
gameSettings.dump(); gameSettings.dump();
globalSettings.dump(); globalSettings.dump();
print(''); printlog('');
board.dump(); board.dump();
print(''); printlog('');
print('Game: '); printlog('Game: ');
print(' isRunning: $isRunning'); printlog(' isRunning: $isRunning');
print(' isFinished: $isFinished'); printlog(' isFinished: $isFinished');
print(' movesCount: $movesCount'); printlog(' movesCount: $movesCount');
print(' score: $score'); printlog(' score: $score');
print(' availableBlocksCount: $availableBlocksCount'); printlog(' availableBlocksCount: $availableBlocksCount');
print(' shuffledColors: $shuffledColors'); printlog(' shuffledColors: $shuffledColors');
print(''); printlog('');
} }
@override @override
......
...@@ -2,6 +2,7 @@ import 'dart:math'; ...@@ -2,6 +2,7 @@ import 'dart:math';
import 'package:jeweled/models/game_cell.dart'; import 'package:jeweled/models/game_cell.dart';
import 'package:jeweled/models/settings_game.dart'; import 'package:jeweled/models/settings_game.dart';
import 'package:jeweled/utils/tools.dart';
class GameBoard { class GameBoard {
final List<List<GameCell>> cells; final List<List<GameCell>> cells;
...@@ -42,8 +43,8 @@ class GameBoard { ...@@ -42,8 +43,8 @@ class GameBoard {
horizontalRule += '-'; horizontalRule += '-';
} }
print('Board:'); printlog('Board:');
print(horizontalRule); printlog(horizontalRule);
for (int rowIndex = 0; rowIndex < cells.length; rowIndex++) { for (int rowIndex = 0; rowIndex < cells.length; rowIndex++) {
String row = '| '; String row = '| ';
...@@ -52,10 +53,10 @@ class GameBoard { ...@@ -52,10 +53,10 @@ class GameBoard {
} }
row += ' |'; row += ' |';
print(row); printlog(row);
} }
print(horizontalRule); printlog(horizontalRule);
} }
@override @override
......
import 'package:jeweled/config/default_game_settings.dart'; import 'package:jeweled/config/default_game_settings.dart';
import 'package:jeweled/utils/tools.dart';
class GameSettings { class GameSettings {
final int boardSize; final int boardSize;
...@@ -33,9 +34,9 @@ class GameSettings { ...@@ -33,9 +34,9 @@ class GameSettings {
} }
void dump() { void dump() {
print('Settings: '); printlog('Settings: ');
print(' boardSize: $boardSize'); printlog(' boardSize: $boardSize');
print(' colorsCount: $colorsCount'); printlog(' colorsCount: $colorsCount');
} }
@override @override
......
import 'package:jeweled/config/default_global_settings.dart'; import 'package:jeweled/config/default_global_settings.dart';
import 'package:jeweled/utils/tools.dart';
class GlobalSettings { class GlobalSettings {
final int colorsTheme; final int colorsTheme;
...@@ -33,9 +34,9 @@ class GlobalSettings { ...@@ -33,9 +34,9 @@ class GlobalSettings {
} }
void dump() { void dump() {
print('Settings: '); printlog('Settings: ');
print(' colorsTheme: $colorsTheme'); printlog(' colorsTheme: $colorsTheme');
print(' graphicTheme: $graphicTheme'); printlog(' graphicTheme: $graphicTheme');
} }
@override @override
......
...@@ -9,6 +9,7 @@ import 'package:jeweled/models/settings_game.dart'; ...@@ -9,6 +9,7 @@ import 'package:jeweled/models/settings_game.dart';
import 'package:jeweled/models/settings_global.dart'; import 'package:jeweled/models/settings_global.dart';
import 'package:jeweled/utils/color_extensions.dart'; import 'package:jeweled/utils/color_extensions.dart';
import 'package:jeweled/utils/color_theme.dart'; import 'package:jeweled/utils/color_theme.dart';
import 'package:jeweled/utils/tools.dart';
class ParameterPainter extends CustomPainter { class ParameterPainter extends CustomPainter {
const ParameterPainter({ const ParameterPainter({
...@@ -39,7 +40,8 @@ class ParameterPainter extends CustomPainter { ...@@ -39,7 +40,8 @@ class ParameterPainter extends CustomPainter {
paint.color = isSelected ? borderColorEnabled : borderColorDisabled; paint.color = isSelected ? borderColorEnabled : borderColorDisabled;
paint.strokeJoin = StrokeJoin.round; paint.strokeJoin = StrokeJoin.round;
paint.strokeWidth = 20 / 100 * canvasSize; paint.strokeWidth = 20 / 100 * canvasSize;
canvas.drawRect(Rect.fromPoints(const Offset(0, 0), Offset(canvasSize, canvasSize)), paint); canvas.drawRect(
Rect.fromPoints(const Offset(0, 0), Offset(canvasSize, canvasSize)), paint);
// content // content
switch (code) { switch (code) {
...@@ -56,7 +58,7 @@ class ParameterPainter extends CustomPainter { ...@@ -56,7 +58,7 @@ class ParameterPainter extends CustomPainter {
paintGraphicThemeParameterItem(value, canvas, canvasSize); paintGraphicThemeParameterItem(value, canvas, canvasSize);
break; break;
default: default:
print('Unknown parameter: $code/$value'); printlog('Unknown parameter: $code/$value');
paintUnknownParameterItem(value, canvas, canvasSize); paintUnknownParameterItem(value, canvas, canvasSize);
} }
} }
...@@ -128,7 +130,7 @@ class ParameterPainter extends CustomPainter { ...@@ -128,7 +130,7 @@ class ParameterPainter extends CustomPainter {
gridWidth = 5; gridWidth = 5;
break; break;
default: default:
print('Wrong value for boardSize parameter value: $value'); printlog('Wrong value for boardSize parameter value: $value');
} }
final paint = Paint(); final paint = Paint();
...@@ -186,7 +188,7 @@ class ParameterPainter extends CustomPainter { ...@@ -186,7 +188,7 @@ class ParameterPainter extends CustomPainter {
backgroundColor = Colors.purple; backgroundColor = Colors.purple;
break; break;
default: default:
print('Wrong value for colorsCount parameter value: $value'); printlog('Wrong value for colorsCount parameter value: $value');
} }
final paint = Paint(); final paint = Paint();
...@@ -347,7 +349,7 @@ class ParameterPainter extends CustomPainter { ...@@ -347,7 +349,7 @@ class ParameterPainter extends CustomPainter {
contentStrings = DefaultGlobalSettings.graphicThemeContentPatternStrings; contentStrings = DefaultGlobalSettings.graphicThemeContentPatternStrings;
break; break;
default: default:
print('Wrong value for colorsCount parameter value: $value'); printlog('Wrong value for colorsCount parameter value: $value');
} }
for (int itemValue = 0; itemValue < positions.length; itemValue++) { for (int itemValue = 0; itemValue < positions.length; itemValue++) {
......
import 'package:flutter/foundation.dart';
void printlog(String message) {
if (!kReleaseMode) {
debugPrint(message);
}
}
...@@ -252,10 +252,10 @@ packages: ...@@ -252,10 +252,10 @@ packages:
dependency: transitive dependency: transitive
description: description:
name: provider name: provider
sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev" url: "https://pub.dev"
source: hosted source: hosted
version: "6.1.1" version: "6.1.2"
shared_preferences: shared_preferences:
dependency: transitive dependency: transitive
description: description:
......
...@@ -3,7 +3,7 @@ description: Jeweled Game ...@@ -3,7 +3,7 @@ description: Jeweled Game
publish_to: 'none' publish_to: 'none'
version: 0.0.26+26 version: 0.0.27+27
environment: environment:
sdk: '^3.0.0' sdk: '^3.0.0'
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment