From 1d8258adf7003000e7498b018fd47109a6b6952a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr>
Date: Tue, 27 Feb 2024 17:04:13 +0100
Subject: [PATCH] Avoid print calls in production code
---
android/gradle.properties | 4 ++--
fastlane/metadata/android/en-US/changelogs/61.txt | 1 +
fastlane/metadata/android/fr-FR/changelogs/61.txt | 1 +
lib/main.dart | 3 ++-
lib/utils/random_pick_words.dart | 5 +++--
lib/utils/tools.dart | 7 +++++++
pubspec.lock | 4 ++--
pubspec.yaml | 2 +-
8 files changed, 19 insertions(+), 8 deletions(-)
create mode 100644 fastlane/metadata/android/en-US/changelogs/61.txt
create mode 100644 fastlane/metadata/android/fr-FR/changelogs/61.txt
create mode 100644 lib/utils/tools.dart
diff --git a/android/gradle.properties b/android/gradle.properties
index 335d0fa..75ca4b7 100644
--- a/android/gradle.properties
+++ b/android/gradle.properties
@@ -1,5 +1,5 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
-app.versionName=0.1.36
-app.versionCode=60
+app.versionName=0.1.37
+app.versionCode=61
diff --git a/fastlane/metadata/android/en-US/changelogs/61.txt b/fastlane/metadata/android/en-US/changelogs/61.txt
new file mode 100644
index 0000000..52f2179
--- /dev/null
+++ b/fastlane/metadata/android/en-US/changelogs/61.txt
@@ -0,0 +1 @@
+Avoid print calls in production code.
diff --git a/fastlane/metadata/android/fr-FR/changelogs/61.txt b/fastlane/metadata/android/fr-FR/changelogs/61.txt
new file mode 100644
index 0000000..8537dac
--- /dev/null
+++ b/fastlane/metadata/android/fr-FR/changelogs/61.txt
@@ -0,0 +1 @@
+Supprime les appels à print dans le code de production.
diff --git a/lib/main.dart b/lib/main.dart
index 0223044..714a9fa 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -6,6 +6,7 @@ import 'package:wordguessing/provider/data.dart';
import 'package:wordguessing/screens/game_pick_image.dart';
import 'package:wordguessing/screens/game_pick_word.dart';
import 'package:wordguessing/screens/home.dart';
+import 'package:wordguessing/utils/tools.dart';
void main() {
WidgetsFlutterBinding.ensureInitialized();
@@ -38,7 +39,7 @@ class MyApp extends StatelessWidget {
);
default:
- print("Unknown menu entry");
+ printlog("Unknown menu entry");
}
return null;
diff --git a/lib/utils/random_pick_words.dart b/lib/utils/random_pick_words.dart
index a65f418..f5c3c17 100644
--- a/lib/utils/random_pick_words.dart
+++ b/lib/utils/random_pick_words.dart
@@ -4,6 +4,7 @@ import 'dart:convert';
import 'package:flutter/services.dart';
import 'package:wordguessing/models/word.dart';
+import 'package:wordguessing/utils/tools.dart';
class RandomPickWords {
RandomPickWords();
@@ -39,12 +40,12 @@ class RandomPickWords {
}
});
} catch (e) {
- print("$e");
+ printlog("$e");
}
// Check we have enough words
if (wordList.length < count) {
- print('Not enough words in list.');
+ printlog('Not enough words in list.');
}
// Remove empty words
diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart
new file mode 100644
index 0000000..fd48b2b
--- /dev/null
+++ b/lib/utils/tools.dart
@@ -0,0 +1,7 @@
+import 'package:flutter/foundation.dart';
+
+void printlog(String message) {
+ if (!kReleaseMode) {
+ debugPrint(message);
+ }
+}
diff --git a/pubspec.lock b/pubspec.lock
index 4abc6fe..b15ebfb 100644
--- a/pubspec.lock
+++ b/pubspec.lock
@@ -66,10 +66,10 @@ packages:
dependency: "direct main"
description:
name: provider
- sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096"
+ sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev"
source: hosted
- version: "6.1.1"
+ version: "6.1.2"
sky_engine:
dependency: transitive
description: flutter
diff --git a/pubspec.yaml b/pubspec.yaml
index 5ae784a..e51ed22 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,7 +1,7 @@
name: wordguessing
description: A wordguessing game application.
publish_to: 'none'
-version: 0.1.36+60
+version: 0.1.37+61
environment:
sdk: '^3.0.0'
--
GitLab