From 24bfa1f5e896b802f41e6affb5b26bcdbe66722a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Tue, 27 Feb 2024 17:03:32 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- fastlane/metadata/android/en-US/changelogs/20.txt | 1 + fastlane/metadata/android/fr-FR/changelogs/20.txt | 1 + lib/board.dart | 2 +- lib/cpu.dart | 6 +++--- lib/cpu_level_page.dart | 4 ++-- lib/game_chip.dart | 2 +- lib/home_page.dart | 4 ++-- lib/main.dart | 1 + lib/match_page.dart | 10 +++++----- lib/utils/tools.dart | 7 +++++++ pubspec.yaml | 2 +- 12 files changed, 27 insertions(+), 17 deletions(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/20.txt create mode 100644 fastlane/metadata/android/fr-FR/changelogs/20.txt create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index 53f7ea2..6d853d4 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=1.0.18 -app.versionCode=19 +app.versionName=1.0.19 +app.versionCode=20 diff --git a/fastlane/metadata/android/en-US/changelogs/20.txt b/fastlane/metadata/android/en-US/changelogs/20.txt new file mode 100644 index 0000000..52f2179 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/20.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/20.txt b/fastlane/metadata/android/fr-FR/changelogs/20.txt new file mode 100644 index 0000000..8537dac --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/20.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/board.dart b/lib/board.dart index 01afbc3..e7498f8 100644 --- a/lib/board.dart +++ b/lib/board.dart @@ -1,6 +1,6 @@ import 'package:puissance4/coordinate.dart'; -import 'match_page.dart'; +import 'package:puissance4/match_page.dart'; class Board { List<List<Color?>> _boxes = List.generate( diff --git a/lib/cpu.dart b/lib/cpu.dart index ff842ed..1f7ed4b 100644 --- a/lib/cpu.dart +++ b/lib/cpu.dart @@ -1,8 +1,8 @@ import 'dart:math'; -import 'board.dart'; -import 'coordinate.dart'; -import 'match_page.dart'; +import 'package:puissance4/board.dart'; +import 'package:puissance4/coordinate.dart'; +import 'package:puissance4/match_page.dart'; abstract class Cpu { final Color color; diff --git a/lib/cpu_level_page.dart b/lib/cpu_level_page.dart index d12af0c..21074f4 100644 --- a/lib/cpu_level_page.dart +++ b/lib/cpu_level_page.dart @@ -1,9 +1,9 @@ import 'dart:math'; import 'package:flutter/material.dart'; -import 'package:puissance4/cpu.dart'; -import 'match_page.dart'; +import 'package:puissance4/cpu.dart'; +import 'package:puissance4/match_page.dart'; class CpuLevelPage extends StatelessWidget { const CpuLevelPage({super.key}); diff --git a/lib/game_chip.dart b/lib/game_chip.dart index 57effba..22d9416 100644 --- a/lib/game_chip.dart +++ b/lib/game_chip.dart @@ -1,6 +1,6 @@ import 'package:flutter/material.dart'; -import 'match_page.dart'; +import 'package:puissance4/match_page.dart'; class GameChip extends StatelessWidget { const GameChip({ diff --git a/lib/home_page.dart b/lib/home_page.dart index 6613982..ab7d325 100644 --- a/lib/home_page.dart +++ b/lib/home_page.dart @@ -1,9 +1,9 @@ import 'dart:math'; import 'package:flutter/material.dart'; -import 'package:puissance4/cpu.dart'; -import 'match_page.dart'; +import 'package:puissance4/cpu.dart'; +import 'package:puissance4/match_page.dart'; class HomePage extends StatelessWidget { const HomePage({super.key}); diff --git a/lib/main.dart b/lib/main.dart index e2785b8..8a2676a 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -1,5 +1,6 @@ import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; + import 'package:puissance4/cpu_level_page.dart'; import 'package:puissance4/home_page.dart'; import 'package:puissance4/match_page.dart'; diff --git a/lib/match_page.dart b/lib/match_page.dart index 66b498b..b9a98bd 100644 --- a/lib/match_page.dart +++ b/lib/match_page.dart @@ -1,12 +1,12 @@ import 'dart:math'; import 'package:flutter/material.dart'; -import 'package:puissance4/coordinate.dart'; -import 'board.dart'; -import 'cpu.dart'; -import 'game_chip.dart'; -import 'hole_painter.dart'; +import 'package:puissance4/board.dart'; +import 'package:puissance4/coordinate.dart'; +import 'package:puissance4/cpu.dart'; +import 'package:puissance4/game_chip.dart'; +import 'package:puissance4/hole_painter.dart'; enum Color { yellow, diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.yaml b/pubspec.yaml index 4f0a45d..f29024e 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: puissance4 description: puissance4 publish_to: 'none' -version: 1.0.18+19 +version: 1.0.19+20 environment: sdk: '^3.0.0' -- GitLab