From 946eebe5b0d4683696c9100dbc874badb30c3f47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Tue, 27 Feb 2024 17:03:45 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- fastlane/metadata/android/en-US/changelogs/33.txt | 1 + fastlane/metadata/android/fr-FR/changelogs/33.txt | 1 + lib/main.dart | 4 ++-- lib/screens/home.dart | 10 +++++----- lib/utils/random_pick_category.dart | 3 ++- lib/utils/tools.dart | 7 +++++++ pubspec.lock | 4 ++-- pubspec.yaml | 2 +- 9 files changed, 23 insertions(+), 13 deletions(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/33.txt create mode 100644 fastlane/metadata/android/fr-FR/changelogs/33.txt create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index da5425f..6bd02e9 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=1.2.26 -app.versionCode=32 +app.versionName=1.2.27 +app.versionCode=33 diff --git a/fastlane/metadata/android/en-US/changelogs/33.txt b/fastlane/metadata/android/en-US/changelogs/33.txt new file mode 100644 index 0000000..52f2179 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/33.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/33.txt b/fastlane/metadata/android/fr-FR/changelogs/33.txt new file mode 100644 index 0000000..8537dac --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/33.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/main.dart b/lib/main.dart index e88a410..099ea04 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -2,8 +2,8 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; import 'package:flutter/services.dart'; -import 'provider/data.dart'; -import 'screens/home.dart'; +import 'package:petitbac/provider/data.dart'; +import 'package:petitbac/screens/home.dart'; void main() { WidgetsFlutterBinding.ensureInitialized(); diff --git a/lib/screens/home.dart b/lib/screens/home.dart index 1621dc9..c54e9a6 100644 --- a/lib/screens/home.dart +++ b/lib/screens/home.dart @@ -1,11 +1,11 @@ +import 'dart:async'; + import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import 'dart:async'; - -import '../provider/data.dart'; -import '../utils/random_pick_category.dart'; -import '../utils/random_pick_letter.dart'; +import 'package:petitbac/provider/data.dart'; +import 'package:petitbac/utils/random_pick_category.dart'; +import 'package:petitbac/utils/random_pick_letter.dart'; class Home extends StatelessWidget { const Home({super.key}); diff --git a/lib/utils/random_pick_category.dart b/lib/utils/random_pick_category.dart index 41b9947..0132446 100644 --- a/lib/utils/random_pick_category.dart +++ b/lib/utils/random_pick_category.dart @@ -1,8 +1,9 @@ import 'dart:async'; import 'dart:convert'; -import 'package:flutter/services.dart'; import 'dart:math' show Random; +import 'package:flutter/services.dart'; + class RandomPickCategory { RandomPickCategory(); diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.lock b/pubspec.lock index 4abc6fe..b15ebfb 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -66,10 +66,10 @@ packages: dependency: "direct main" description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" sky_engine: dependency: transitive description: flutter diff --git a/pubspec.yaml b/pubspec.yaml index a2286f8..b482aa6 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: petitbac description: A PetitBac game application. publish_to: 'none' -version: 1.2.26+32 +version: 1.2.27+33 environment: sdk: '^3.0.0' -- GitLab