diff --git a/android/gradle.properties b/android/gradle.properties index 39d5a5ef59711601465011714696a22deab9a41c..f012e12b8d2def2d685882de50fb89c3df5a47cd 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=0.0.54 -app.versionCode=54 +app.versionName=0.0.55 +app.versionCode=55 diff --git a/fastlane/metadata/android/en-US/changelogs/55.txt b/fastlane/metadata/android/en-US/changelogs/55.txt new file mode 100644 index 0000000000000000000000000000000000000000..52f2179d505f14dcc88966038849680298d1df24 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/55.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/55.txt b/fastlane/metadata/android/fr-FR/changelogs/55.txt new file mode 100644 index 0000000000000000000000000000000000000000..8537dac9f8ac580dac7eee02b1a1c99a901fe7d2 --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/55.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/ui/widgets/abstracts/custom_chart.dart b/lib/ui/widgets/abstracts/custom_chart.dart index dd294c49c3bff8e9b10d69b936624a2fb64382de..e0e69fbce22c64e144de072118c07d51e9d1f158 100644 --- a/lib/ui/widgets/abstracts/custom_chart.dart +++ b/lib/ui/widgets/abstracts/custom_chart.dart @@ -216,8 +216,7 @@ class CustomChart extends StatelessWidget { } Widget getVerticalTitlesWidgetWithValue(double value, TitleMeta meta) { - String suffix = - verticalAxisTitleSuffix != '' ? ' $verticalAxisTitleSuffix' : ''; + String suffix = verticalAxisTitleSuffix != '' ? ' $verticalAxisTitleSuffix' : ''; return SideTitleWidget( axisSide: meta.axisSide, diff --git a/lib/ui/widgets/charts/counts_by_day.dart b/lib/ui/widgets/charts/counts_by_day.dart index ebded1d870dff751f0c7a4d35ca87e6e115e1147..e571aa9ddbd41ba20df4de82049b4f3369a3d318 100644 --- a/lib/ui/widgets/charts/counts_by_day.dart +++ b/lib/ui/widgets/charts/counts_by_day.dart @@ -43,11 +43,9 @@ class ChartCountsByDay extends CustomBarChart { double maxValue = 0; for (var key in chartData.data.keys) { - double? counts = chartData.data[key]; - if (counts != null) { - if (counts > maxValue) { - maxValue = counts; - } + double counts = chartData.data[key] ?? 0; + if (counts > maxValue) { + maxValue = counts; } } diff --git a/lib/ui/widgets/charts/counts_by_hour.dart b/lib/ui/widgets/charts/counts_by_hour.dart index fc423899f5902add58883cd63e441124aa007567..4bc2bf8ead411dbe3f350e15590d198f23340b7a 100644 --- a/lib/ui/widgets/charts/counts_by_hour.dart +++ b/lib/ui/widgets/charts/counts_by_hour.dart @@ -45,11 +45,9 @@ class ChartCountsByHour extends CustomBarChart { double maxValue = 0; for (var key in chartData.data.keys) { - double? counts = chartData.data[key]; - if (counts != null) { - if (counts > maxValue) { - maxValue = counts; - } + double counts = chartData.data[key] ?? 0; + if (counts > maxValue) { + maxValue = counts; } } diff --git a/lib/ui/widgets/error.dart b/lib/ui/widgets/error.dart index 2a68880c0c45daf6272e4bb179a4743d586888a4..aa3d5cd267b3a9ab2903518f8f789bf1b23a2cd6 100644 --- a/lib/ui/widgets/error.dart +++ b/lib/ui/widgets/error.dart @@ -1,6 +1,8 @@ import 'package:easy_localization/easy_localization.dart'; import 'package:flutter/material.dart'; +import 'package:scrobbles/utils/tools.dart'; + class ShowErrorWidget extends StatelessWidget { const ShowErrorWidget({super.key, required this.message}); @@ -8,7 +10,7 @@ class ShowErrorWidget extends StatelessWidget { @override Widget build(BuildContext context) { - print(message); + printlog(message); return Text( 'âš ï¸ ${tr(message)}', diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000000000000000000000000000000000000..fd48b2b009b80b22248d6e7f08a63e96c4065bd7 --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.lock b/pubspec.lock index f0f67d8ffa857ed9abcc47811f1e73c15f5712fd..5e1b4874edba51cf77a53aaf03978199e127e480 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -300,10 +300,10 @@ packages: dependency: transitive description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" shared_preferences: dependency: transitive description: diff --git a/pubspec.yaml b/pubspec.yaml index 5696fefa725d0d8471afac86a0ba5fd4acb48208..25fa8039ae268bdbeef73be1fd61e5069fe9b39a 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -3,7 +3,7 @@ description: Display scrobbles data and charts publish_to: 'none' -version: 0.0.54+54 +version: 0.0.55+55 environment: sdk: '^3.0.0'