From d1e5226f9d6f36e304a495add61751efb0bf4ecc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr>
Date: Fri, 15 Nov 2024 15:36:44 +0100
Subject: [PATCH] Use ActivityParameters widgets from flutter_custom_toolbox
---
.../metadata/android/en-US/changelogs/26.txt | 1 +
.../metadata/android/fr-FR/changelogs/26.txt | 1 +
lib/common/config/activity_page.dart | 39 +++-
lib/common/ui/pages/parameters.dart | 171 ------------------
.../ui/parameters/parameter_painter.dart | 71 --------
.../ui/parameters/parameter_widget.dart | 65 -------
lib/config/application_config.dart | 68 ++++++-
lib/config/default_activity_settings.dart | 40 ----
lib/config/default_global_settings.dart | 28 ---
lib/cubit/activity/activity_cubit.dart | 18 +-
.../settings/settings_activity_cubit.dart | 73 --------
.../settings/settings_activity_state.dart | 15 --
lib/cubit/settings/settings_global_cubit.dart | 59 ------
lib/cubit/settings/settings_global_state.dart | 15 --
lib/game/game_engine.dart | 4 +-
lib/main.dart | 14 +-
lib/models/activity/activity.dart | 17 +-
lib/models/settings/settings_activity.dart | 59 ------
lib/models/settings/settings_global.dart | 42 -----
lib/{common => }/ui/pages/game.dart | 0
lib/ui/widgets/game/game_board_display.dart | 2 +-
lib/ui/widgets/game/score_box.dart | 2 +-
pubspec.lock | 6 +-
pubspec.yaml | 4 +-
24 files changed, 125 insertions(+), 689 deletions(-)
create mode 100644 fastlane/metadata/android/en-US/changelogs/26.txt
create mode 100644 fastlane/metadata/android/fr-FR/changelogs/26.txt
delete mode 100644 lib/common/ui/pages/parameters.dart
delete mode 100644 lib/common/ui/parameters/parameter_painter.dart
delete mode 100644 lib/common/ui/parameters/parameter_widget.dart
delete mode 100644 lib/config/default_activity_settings.dart
delete mode 100644 lib/config/default_global_settings.dart
delete mode 100644 lib/cubit/settings/settings_activity_cubit.dart
delete mode 100644 lib/cubit/settings/settings_activity_state.dart
delete mode 100644 lib/cubit/settings/settings_global_cubit.dart
delete mode 100644 lib/cubit/settings/settings_global_state.dart
delete mode 100644 lib/models/settings/settings_activity.dart
delete mode 100644 lib/models/settings/settings_global.dart
rename lib/{common => }/ui/pages/game.dart (100%)
diff --git a/fastlane/metadata/android/en-US/changelogs/26.txt b/fastlane/metadata/android/en-US/changelogs/26.txt
new file mode 100644
index 0000000..c20ed39
--- /dev/null
+++ b/fastlane/metadata/android/en-US/changelogs/26.txt
@@ -0,0 +1 @@
+Use ActivityParameters widgets from flutter_custom_toolbox.
diff --git a/fastlane/metadata/android/fr-FR/changelogs/26.txt b/fastlane/metadata/android/fr-FR/changelogs/26.txt
new file mode 100644
index 0000000..f732ebd
--- /dev/null
+++ b/fastlane/metadata/android/fr-FR/changelogs/26.txt
@@ -0,0 +1 @@
+Utilisation des widgets ActivityParameters de flutter_custom_toolbox.
diff --git a/lib/common/config/activity_page.dart b/lib/common/config/activity_page.dart
index d8d600a..9f75a25 100644
--- a/lib/common/config/activity_page.dart
+++ b/lib/common/config/activity_page.dart
@@ -1,18 +1,20 @@
import 'package:flutter/material.dart';
import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-import 'package:reversi/common/ui/pages/game.dart';
-import 'package:reversi/common/ui/pages/parameters.dart';
+import 'package:reversi/config/application_config.dart';
+import 'package:reversi/cubit/activity/activity_cubit.dart';
+import 'package:reversi/models/activity/activity.dart';
+import 'package:reversi/ui/pages/game.dart';
class ActivityPageItem {
final String code;
final Icon icon;
- final Widget page;
+ final Widget Function({required Activity currentActivity})? builder;
const ActivityPageItem({
required this.code,
required this.icon,
- required this.page,
+ required this.builder,
});
}
@@ -20,20 +22,27 @@ class ActivityPage {
static const bool displayBottomNavBar = false;
static const indexHome = 0;
- static const pageHome = ActivityPageItem(
+ static final ActivityPageItem pageHome = ActivityPageItem(
code: 'page_home',
icon: Icon(UniconsLine.home),
- page: PageParameters(),
+ builder: ({required Activity currentActivity}) {
+ return PageParameters(
+ config: ApplicationConfig.config,
+ canBeResumed: currentActivity.canBeResumed,
+ );
+ },
);
static const indexGame = 1;
- static const pageGame = ActivityPageItem(
+ static final pageGame = ActivityPageItem(
code: 'page_game',
icon: Icon(UniconsLine.star),
- page: PageGame(),
+ builder: ({required Activity currentActivity}) {
+ return PageGame();
+ },
);
- static const Map<int, ActivityPageItem> items = {
+ static final Map<int, ActivityPageItem> items = {
indexHome: pageHome,
indexGame: pageGame,
};
@@ -45,6 +54,16 @@ class ActivityPage {
}
static Widget getWidget(int pageIndex) {
- return items[pageIndex]?.page ?? pageHome.page;
+ return BlocBuilder<ActivityCubit, ActivityState>(
+ builder: (BuildContext context, ActivityState activityState) {
+ final Activity currentActivity = activityState.currentActivity;
+
+ if (items.keys.contains(pageIndex)) {
+ return items[pageIndex]?.builder!(currentActivity: currentActivity) ?? Text('oups');
+ } else {
+ return getWidget(defaultPageIndex);
+ }
+ },
+ );
}
}
diff --git a/lib/common/ui/pages/parameters.dart b/lib/common/ui/pages/parameters.dart
deleted file mode 100644
index ca64f16..0000000
--- a/lib/common/ui/pages/parameters.dart
+++ /dev/null
@@ -1,171 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/common/cubit/nav/nav_cubit_pages.dart';
-import 'package:reversi/common/ui/parameters/parameter_widget.dart';
-
-import 'package:reversi/config/default_activity_settings.dart';
-import 'package:reversi/config/default_global_settings.dart';
-import 'package:reversi/cubit/activity/activity_cubit.dart';
-import 'package:reversi/cubit/settings/settings_activity_cubit.dart';
-import 'package:reversi/cubit/settings/settings_global_cubit.dart';
-import 'package:reversi/models/activity/activity.dart';
-
-class PageParameters extends StatelessWidget {
- const PageParameters({super.key});
-
- final double separatorHeight = 8.0;
-
- @override
- Widget build(BuildContext context) {
- return BlocBuilder<ActivitySettingsCubit, ActivitySettingsState>(
- builder: (BuildContext context, ActivitySettingsState activitySettingsState) {
- return BlocBuilder<GlobalSettingsCubit, GlobalSettingsState>(
- builder: (BuildContext context, GlobalSettingsState globalSettingsState) {
- return BlocBuilder<ActivityCubit, ActivityState>(
- builder: (BuildContext context, ActivityState activityState) {
- final Activity currentActivity = activityState.currentActivity;
-
- final List<Widget> lines = [];
-
- // Activity settings
- for (String code in DefaultActivitySettings.availableParameters) {
- lines.add(Row(
- mainAxisAlignment: MainAxisAlignment.spaceBetween,
- children: buildParametersLine(
- code: code,
- isGlobal: false,
- ),
- ));
-
- lines.add(SizedBox(height: separatorHeight));
- }
-
- lines.add(Expanded(
- child: SizedBox(height: separatorHeight),
- ));
-
- if (currentActivity.canBeResumed == false) {
- // Start new activity
- lines.add(
- AspectRatio(
- aspectRatio: 3,
- child: ActivityButtonStartNew(
- onPressed: () {
- BlocProvider.of<ActivityCubit>(context).startNewActivity(
- activitySettings: activitySettingsState.settings,
- globalSettings: globalSettingsState.settings,
- );
- BlocProvider.of<NavCubitPage>(context).goToPageGame();
- },
- ),
- ),
- );
- } else {
- // Resume activity
- lines.add(AspectRatio(
- aspectRatio: 3,
- child: ActivityButtonResumeSaved(
- onPressed: () {
- BlocProvider.of<ActivityCubit>(context).resumeSavedActivity();
- BlocProvider.of<NavCubitPage>(context).goToPageGame();
- },
- ),
- ));
- // Delete saved activity
- lines.add(SizedBox.square(
- dimension: MediaQuery.of(context).size.width / 5,
- child: ActivityButtonDeleteSaved(
- onPressed: () {
- BlocProvider.of<ActivityCubit>(context).deleteSavedActivity();
- },
- ),
- ));
- }
-
- lines.add(SizedBox(height: separatorHeight));
-
- // Global settings
- for (String code in DefaultGlobalSettings.availableParameters) {
- lines.add(Row(
- mainAxisAlignment: MainAxisAlignment.spaceBetween,
- children: buildParametersLine(
- code: code,
- isGlobal: true,
- ),
- ));
-
- lines.add(SizedBox(height: separatorHeight));
- }
-
- return Column(
- children: lines,
- );
- },
- );
- },
- );
- },
- );
- }
-
- List<Widget> buildParametersLine({
- required String code,
- required bool isGlobal,
- }) {
- final List<Widget> parameterButtons = [];
-
- final List<String> availableValues = isGlobal
- ? DefaultGlobalSettings.getAvailableValues(code)
- : DefaultActivitySettings.getAvailableValues(code);
-
- if (availableValues.length <= 1) {
- return [];
- }
-
- for (String value in availableValues) {
- final Widget parameterButton = BlocBuilder<ActivitySettingsCubit, ActivitySettingsState>(
- builder: (BuildContext context, ActivitySettingsState activitySettingsState) {
- return BlocBuilder<GlobalSettingsCubit, GlobalSettingsState>(
- builder: (BuildContext context, GlobalSettingsState globalSettingsState) {
- final ActivitySettingsCubit activitySettingsCubit =
- BlocProvider.of<ActivitySettingsCubit>(context);
- final GlobalSettingsCubit globalSettingsCubit =
- BlocProvider.of<GlobalSettingsCubit>(context);
-
- final String currentValue = isGlobal
- ? globalSettingsCubit.getParameterValue(code)
- : activitySettingsCubit.getParameterValue(code);
-
- final bool isSelected = (value == currentValue);
-
- final double displayWidth = MediaQuery.of(context).size.width;
- final double itemWidth = displayWidth / availableValues.length - 4;
-
- return SizedBox.square(
- dimension: itemWidth,
- child: ParameterWidget(
- code: code,
- value: value,
- isSelected: isSelected,
- size: itemWidth,
- activitySettings: activitySettingsState.settings,
- globalSettings: globalSettingsState.settings,
- onPressed: () {
- isGlobal
- ? globalSettingsCubit.setParameterValue(code, value)
- : activitySettingsCubit.setParameterValue(code, value);
- },
- ),
- );
- },
- );
- },
- );
-
- parameterButtons.add(parameterButton);
- }
-
- return parameterButtons;
- }
-}
diff --git a/lib/common/ui/parameters/parameter_painter.dart b/lib/common/ui/parameters/parameter_painter.dart
deleted file mode 100644
index 2c9afc3..0000000
--- a/lib/common/ui/parameters/parameter_painter.dart
+++ /dev/null
@@ -1,71 +0,0 @@
-import 'dart:math';
-
-import 'package:flutter/material.dart';
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/models/settings/settings_activity.dart';
-import 'package:reversi/models/settings/settings_global.dart';
-
-class ParameterPainter extends CustomPainter {
- const ParameterPainter({
- required this.code,
- required this.value,
- required this.activitySettings,
- required this.globalSettings,
- });
-
- final String code;
- final String value;
- final ActivitySettings activitySettings;
- final GlobalSettings globalSettings;
-
- @override
- void paint(Canvas canvas, Size size) {
- // force square
- final double canvasSize = min(size.width, size.height);
-
- // content
- switch (code) {
- default:
- printlog('Unknown parameter: $code/$value');
- paintUnknownParameterItem(canvas, canvasSize);
- }
- }
-
- @override
- bool shouldRepaint(CustomPainter oldDelegate) {
- return false;
- }
-
- // "unknown" parameter -> simple block with text
- void paintUnknownParameterItem(
- final Canvas canvas,
- final double size,
- ) {
- final paint = Paint();
- paint.strokeJoin = StrokeJoin.round;
- paint.strokeWidth = 3;
-
- final textSpan = TextSpan(
- text: '$code\n$value',
- style: const TextStyle(
- color: Colors.black,
- fontSize: 18,
- fontWeight: FontWeight.bold,
- ),
- );
- final textPainter = TextPainter(
- text: textSpan,
- textDirection: TextDirection.ltr,
- textAlign: TextAlign.center,
- );
- textPainter.layout();
- textPainter.paint(
- canvas,
- Offset(
- (size - textPainter.width) * 0.5,
- (size - textPainter.height) * 0.5,
- ),
- );
- }
-}
diff --git a/lib/common/ui/parameters/parameter_widget.dart b/lib/common/ui/parameters/parameter_widget.dart
deleted file mode 100644
index c572f5f..0000000
--- a/lib/common/ui/parameters/parameter_widget.dart
+++ /dev/null
@@ -1,65 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/models/settings/settings_activity.dart';
-import 'package:reversi/models/settings/settings_global.dart';
-
-class ParameterWidget extends StatelessWidget {
- const ParameterWidget({
- super.key,
- required this.code,
- required this.value,
- required this.isSelected,
- required this.size,
- required this.activitySettings,
- required this.globalSettings,
- required this.onPressed,
- });
-
- final String code;
- final String value;
- final bool isSelected;
- final double size;
- final ActivitySettings activitySettings;
- final GlobalSettings globalSettings;
- final VoidCallback onPressed;
-
- static const Color buttonColorActive = Colors.blue;
- static const Color buttonColorInactive = Colors.white;
- static const double buttonBorderWidth = 4.0;
- static const double buttonBorderRadius = 12.0;
-
- @override
- Widget build(BuildContext context) {
- Widget content = const SizedBox.shrink();
-
- switch (code) {
- default:
- printlog('Unknown parameter: $code/$value');
- content = getUnknownParameterItem();
- }
-
- final Color buttonColor = isSelected ? buttonColorActive : buttonColorInactive;
-
- return Container(
- decoration: BoxDecoration(
- color: buttonColor,
- borderRadius: BorderRadius.circular(buttonBorderRadius),
- border: Border.all(
- color: buttonColor,
- width: buttonBorderWidth,
- ),
- ),
- child: content,
- );
- }
-
- // "unknown" parameter -> simple block with text
- Widget getUnknownParameterItem() {
- return StyledButton.text(
- caption: '$code / $value',
- color: Colors.grey,
- onPressed: null,
- );
- }
-}
diff --git a/lib/config/application_config.dart b/lib/config/application_config.dart
index 2598e37..98df494 100644
--- a/lib/config/application_config.dart
+++ b/lib/config/application_config.dart
@@ -1,3 +1,69 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
+
+import 'package:reversi/common/cubit/nav/nav_cubit_pages.dart';
+
+import 'package:reversi/cubit/activity/activity_cubit.dart';
+
class ApplicationConfig {
- static const String appTitle = 'Reversi';
+ // skin
+ static const String parameterCodeSkin = 'global.skin';
+ static const String skinValueDefault = 'default';
+
+ // game mode
+ static const String parameterCodeGameMode = 'gameMode';
+ static const String gameModeValueMedium = 'human-vs-cpu';
+
+ // difficulty level
+ static const String parameterCodeDifficultyLevel = 'difficultyLevel';
+ static const String difficultyLevelMedium = 'medium';
+
+ static final ApplicationConfigDefinition config = ApplicationConfigDefinition(
+ appTitle: 'Reversi',
+ activitySettings: [
+ // skin
+ ApplicationSettingsParameter(
+ code: parameterCodeSkin,
+ values: [
+ ApplicationSettingsParameterItemValue(
+ value: skinValueDefault,
+ isDefault: true,
+ ),
+ ],
+ ),
+
+ // game mode
+ ApplicationSettingsParameter(
+ code: parameterCodeGameMode,
+ values: [
+ ApplicationSettingsParameterItemValue(
+ value: gameModeValueMedium,
+ isDefault: true,
+ ),
+ ],
+ ),
+
+ // difficulty level
+ ApplicationSettingsParameter(
+ code: parameterCodeDifficultyLevel,
+ values: [
+ ApplicationSettingsParameterItemValue(
+ value: difficultyLevelMedium,
+ isDefault: true,
+ ),
+ ],
+ ),
+ ],
+ startNewActivity: (BuildContext context) {
+ BlocProvider.of<ActivityCubit>(context).startNewActivity(context);
+ BlocProvider.of<NavCubitPage>(context).goToPageGame();
+ },
+ deleteCurrentActivity: (BuildContext context) {
+ BlocProvider.of<ActivityCubit>(context).deleteSavedActivity();
+ },
+ resumeActivity: (BuildContext context) {
+ BlocProvider.of<ActivityCubit>(context).resumeSavedActivity();
+ BlocProvider.of<NavCubitPage>(context).goToPageGame();
+ },
+ );
}
diff --git a/lib/config/default_activity_settings.dart b/lib/config/default_activity_settings.dart
deleted file mode 100644
index aed569b..0000000
--- a/lib/config/default_activity_settings.dart
+++ /dev/null
@@ -1,40 +0,0 @@
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-class DefaultActivitySettings {
- // available game parameters codes
- static const String parameterCodeGameMode = 'gameMode';
- static const String parameterCodeDifficultyLevel = 'difficultyLevel';
- static const List<String> availableParameters = [
- parameterCodeGameMode,
- parameterCodeDifficultyLevel,
- ];
-
- // game mode: available values
- static const String gameModeValueMedium = 'human-vs-cpu';
- static const List<String> allowedGameModeValues = [
- gameModeValueMedium,
- ];
- // game mode: default value
- static const String defaultGameModeValue = gameModeValueMedium;
-
- // difficulty level: available values
- static const String difficultyLevelMedium = 'medium';
- static const List<String> allowedDifficultyLevelValues = [
- difficultyLevelMedium,
- ];
- // difficulty level: default value
- static const String difficultyLevelValue = difficultyLevelMedium;
-
- // available values from parameter code
- static List<String> getAvailableValues(String parameterCode) {
- switch (parameterCode) {
- case parameterCodeGameMode:
- return DefaultActivitySettings.allowedGameModeValues;
- case parameterCodeDifficultyLevel:
- return DefaultActivitySettings.allowedDifficultyLevelValues;
- }
-
- printlog('Did not find any available value for game parameter "$parameterCode".');
- return [];
- }
-}
diff --git a/lib/config/default_global_settings.dart b/lib/config/default_global_settings.dart
deleted file mode 100644
index d92229c..0000000
--- a/lib/config/default_global_settings.dart
+++ /dev/null
@@ -1,28 +0,0 @@
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-class DefaultGlobalSettings {
- // available global parameters codes
- static const String parameterCodeSkin = 'skin';
- static const List<String> availableParameters = [
- parameterCodeSkin,
- ];
-
- // skin: available values
- static const String skinValueDefault = 'default';
- static const List<String> allowedSkinValues = [
- skinValueDefault,
- ];
- // skin: default value
- static const String defaultSkinValue = skinValueDefault;
-
- // available values from parameter code
- static List<String> getAvailableValues(String parameterCode) {
- switch (parameterCode) {
- case parameterCodeSkin:
- return DefaultGlobalSettings.allowedSkinValues;
- }
-
- printlog('Did not find any available value for global parameter "$parameterCode".');
- return [];
- }
-}
diff --git a/lib/cubit/activity/activity_cubit.dart b/lib/cubit/activity/activity_cubit.dart
index 46295a6..59cfde5 100644
--- a/lib/cubit/activity/activity_cubit.dart
+++ b/lib/cubit/activity/activity_cubit.dart
@@ -2,8 +2,6 @@ import 'package:flutter/material.dart';
import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
import 'package:reversi/models/activity/activity.dart';
-import 'package:reversi/models/settings/settings_activity.dart';
-import 'package:reversi/models/settings/settings_global.dart';
part 'activity_state.dart';
@@ -23,7 +21,6 @@ class ActivityCubit extends HydratedCubit<ActivityState> {
final Activity activity = Activity(
// Settings
activitySettings: state.currentActivity.activitySettings,
- globalSettings: state.currentActivity.globalSettings,
// State
isRunning: state.currentActivity.isRunning,
isStarted: state.currentActivity.isStarted,
@@ -39,14 +36,13 @@ class ActivityCubit extends HydratedCubit<ActivityState> {
updateState(activity);
}
- void startNewActivity({
- required ActivitySettings activitySettings,
- required GlobalSettings globalSettings,
- }) {
+ void startNewActivity(BuildContext context) {
+ final ActivitySettingsCubit activitySettingsCubit =
+ BlocProvider.of<ActivitySettingsCubit>(context);
+
final Activity newActivity = Activity.createNew(
// Settings
- activitySettings: activitySettings,
- globalSettings: globalSettings,
+ activitySettings: activitySettingsCubit.state.settings,
);
newActivity.dump();
@@ -55,6 +51,10 @@ class ActivityCubit extends HydratedCubit<ActivityState> {
refresh();
}
+ bool canBeResumed() {
+ return state.currentActivity.canBeResumed;
+ }
+
void quitActivity() {
state.currentActivity.isRunning = false;
refresh();
diff --git a/lib/cubit/settings/settings_activity_cubit.dart b/lib/cubit/settings/settings_activity_cubit.dart
deleted file mode 100644
index b332839..0000000
--- a/lib/cubit/settings/settings_activity_cubit.dart
+++ /dev/null
@@ -1,73 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/config/default_activity_settings.dart';
-import 'package:reversi/models/settings/settings_activity.dart';
-
-part 'settings_activity_state.dart';
-
-class ActivitySettingsCubit extends HydratedCubit<ActivitySettingsState> {
- ActivitySettingsCubit()
- : super(ActivitySettingsState(settings: ActivitySettings.createDefault()));
-
- void setValues({
- String? itemsCount,
- String? timerValue,
- }) {
- emit(
- ActivitySettingsState(
- settings: ActivitySettings(
- itemsCount: itemsCount ?? state.settings.itemsCount,
- timerValue: timerValue ?? state.settings.timerValue,
- ),
- ),
- );
- }
-
- String getParameterValue(String code) {
- switch (code) {
- case DefaultActivitySettings.parameterCodeGameMode:
- return ActivitySettings.getItemsCountValueFromUnsafe(state.settings.itemsCount);
- case DefaultActivitySettings.parameterCodeDifficultyLevel:
- return ActivitySettings.getTimerValueFromUnsafe(state.settings.timerValue);
- }
-
- return '';
- }
-
- void setParameterValue(String code, String value) {
- final String itemsCount = code == DefaultActivitySettings.parameterCodeGameMode
- ? value
- : getParameterValue(DefaultActivitySettings.parameterCodeGameMode);
- final String timerValue = code == DefaultActivitySettings.parameterCodeDifficultyLevel
- ? value
- : getParameterValue(DefaultActivitySettings.parameterCodeDifficultyLevel);
-
- setValues(
- itemsCount: itemsCount,
- timerValue: timerValue,
- );
- }
-
- @override
- ActivitySettingsState? fromJson(Map<String, dynamic> json) {
- final String itemsCount = json[DefaultActivitySettings.parameterCodeGameMode] as String;
- final String timerValue =
- json[DefaultActivitySettings.parameterCodeDifficultyLevel] as String;
-
- return ActivitySettingsState(
- settings: ActivitySettings(
- itemsCount: itemsCount,
- timerValue: timerValue,
- ),
- );
- }
-
- @override
- Map<String, dynamic>? toJson(ActivitySettingsState state) {
- return <String, dynamic>{
- DefaultActivitySettings.parameterCodeGameMode: state.settings.itemsCount,
- DefaultActivitySettings.parameterCodeDifficultyLevel: state.settings.timerValue,
- };
- }
-}
diff --git a/lib/cubit/settings/settings_activity_state.dart b/lib/cubit/settings/settings_activity_state.dart
deleted file mode 100644
index 2b2de42..0000000
--- a/lib/cubit/settings/settings_activity_state.dart
+++ /dev/null
@@ -1,15 +0,0 @@
-part of 'settings_activity_cubit.dart';
-
-@immutable
-class ActivitySettingsState extends Equatable {
- const ActivitySettingsState({
- required this.settings,
- });
-
- final ActivitySettings settings;
-
- @override
- List<dynamic> get props => <dynamic>[
- settings,
- ];
-}
diff --git a/lib/cubit/settings/settings_global_cubit.dart b/lib/cubit/settings/settings_global_cubit.dart
deleted file mode 100644
index 95bdb30..0000000
--- a/lib/cubit/settings/settings_global_cubit.dart
+++ /dev/null
@@ -1,59 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/config/default_global_settings.dart';
-import 'package:reversi/models/settings/settings_global.dart';
-
-part 'settings_global_state.dart';
-
-class GlobalSettingsCubit extends HydratedCubit<GlobalSettingsState> {
- GlobalSettingsCubit() : super(GlobalSettingsState(settings: GlobalSettings.createDefault()));
-
- void setValues({
- String? skin,
- }) {
- emit(
- GlobalSettingsState(
- settings: GlobalSettings(
- skin: skin ?? state.settings.skin,
- ),
- ),
- );
- }
-
- String getParameterValue(String code) {
- switch (code) {
- case DefaultGlobalSettings.parameterCodeSkin:
- return GlobalSettings.getSkinValueFromUnsafe(state.settings.skin);
- }
- return '';
- }
-
- void setParameterValue(String code, String value) {
- final String skin = (code == DefaultGlobalSettings.parameterCodeSkin)
- ? value
- : getParameterValue(DefaultGlobalSettings.parameterCodeSkin);
-
- setValues(
- skin: skin,
- );
- }
-
- @override
- GlobalSettingsState? fromJson(Map<String, dynamic> json) {
- final String skin = json[DefaultGlobalSettings.parameterCodeSkin] as String;
-
- return GlobalSettingsState(
- settings: GlobalSettings(
- skin: skin,
- ),
- );
- }
-
- @override
- Map<String, dynamic>? toJson(GlobalSettingsState state) {
- return <String, dynamic>{
- DefaultGlobalSettings.parameterCodeSkin: state.settings.skin,
- };
- }
-}
diff --git a/lib/cubit/settings/settings_global_state.dart b/lib/cubit/settings/settings_global_state.dart
deleted file mode 100644
index ebcddd7..0000000
--- a/lib/cubit/settings/settings_global_state.dart
+++ /dev/null
@@ -1,15 +0,0 @@
-part of 'settings_global_cubit.dart';
-
-@immutable
-class GlobalSettingsState extends Equatable {
- const GlobalSettingsState({
- required this.settings,
- });
-
- final GlobalSettings settings;
-
- @override
- List<dynamic> get props => <dynamic>[
- settings,
- ];
-}
diff --git a/lib/game/game_engine.dart b/lib/game/game_engine.dart
index 1e3b457..e3d689d 100644
--- a/lib/game/game_engine.dart
+++ b/lib/game/game_engine.dart
@@ -6,11 +6,11 @@ import 'dart:async';
import 'package:async/async.dart';
import 'package:flutter/material.dart';
-
import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-import 'package:reversi/ai/move_finder.dart';
import 'package:reversi/common/cubit/nav/nav_cubit_pages.dart';
+
+import 'package:reversi/ai/move_finder.dart';
import 'package:reversi/config/styling.dart';
import 'package:reversi/cubit/activity/activity_cubit.dart';
import 'package:reversi/models/activity/game_board.dart';
diff --git a/lib/main.dart b/lib/main.dart
index bd9900a..abbf711 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -8,10 +8,7 @@ import 'package:reversi/common/cubit/nav/nav_cubit_pages.dart';
import 'package:reversi/common/cubit/nav/nav_cubit_screens.dart';
import 'package:reversi/config/application_config.dart';
-import 'package:reversi/config/default_global_settings.dart';
import 'package:reversi/cubit/activity/activity_cubit.dart';
-import 'package:reversi/cubit/settings/settings_activity_cubit.dart';
-import 'package:reversi/cubit/settings/settings_global_cubit.dart';
import 'package:reversi/ui/skeleton.dart';
void main() async {
@@ -62,17 +59,14 @@ class MyApp extends StatelessWidget {
BlocProvider<ActivityCubit>(
create: (context) => ActivityCubit(),
),
- BlocProvider<GlobalSettingsCubit>(
- create: (context) => GlobalSettingsCubit(),
- ),
BlocProvider<ActivitySettingsCubit>(
- create: (context) => ActivitySettingsCubit(),
+ create: (context) => ActivitySettingsCubit(appConfig: ApplicationConfig.config),
),
],
child: BlocBuilder<ApplicationThemeModeCubit, ApplicationThemeModeState>(
builder: (BuildContext context, ApplicationThemeModeState state) {
return MaterialApp(
- title: ApplicationConfig.appTitle,
+ title: ApplicationConfig.config.appTitle,
home: const SkeletonScreen(),
// Theme stuff
@@ -110,7 +104,9 @@ class MyApp extends StatelessWidget {
'tile_white',
];
- for (String skin in DefaultGlobalSettings.allowedSkinValues) {
+ for (String skin in ApplicationConfig.config
+ .getFromCode(ApplicationConfig.parameterCodeSkin)
+ .allowedValues) {
for (String image in skinImages) {
assets.add('assets/skins/${skin}_$image.png');
}
diff --git a/lib/models/activity/activity.dart b/lib/models/activity/activity.dart
index 978b3d2..43e3be7 100644
--- a/lib/models/activity/activity.dart
+++ b/lib/models/activity/activity.dart
@@ -1,15 +1,13 @@
import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
+import 'package:reversi/config/application_config.dart';
import 'package:reversi/models/activity/game_board.dart';
import 'package:reversi/models/activity/game_model.dart';
-import 'package:reversi/models/settings/settings_activity.dart';
-import 'package:reversi/models/settings/settings_global.dart';
class Activity {
Activity({
// Settings
required this.activitySettings,
- required this.globalSettings,
// State
this.isRunning = false,
@@ -26,7 +24,6 @@ class Activity {
// Settings
final ActivitySettings activitySettings;
- final GlobalSettings globalSettings;
// State
bool isRunning;
@@ -43,8 +40,7 @@ class Activity {
factory Activity.createNull() {
return Activity(
// Settings
- activitySettings: ActivitySettings.createDefault(),
- globalSettings: GlobalSettings.createDefault(),
+ activitySettings: ActivitySettings.createDefault(appConfig: ApplicationConfig.config),
// Base data
gameModel: GameModel(board: GameBoard()),
// Game data
@@ -54,16 +50,13 @@ class Activity {
factory Activity.createNew({
ActivitySettings? activitySettings,
- GlobalSettings? globalSettings,
}) {
- final ActivitySettings newActivitySettings =
- activitySettings ?? ActivitySettings.createDefault();
- final GlobalSettings newGlobalSettings = globalSettings ?? GlobalSettings.createDefault();
+ final ActivitySettings newActivitySettings = activitySettings ??
+ ActivitySettings.createDefault(appConfig: ApplicationConfig.config);
return Activity(
// Settings
activitySettings: newActivitySettings,
- globalSettings: newGlobalSettings,
// State
isRunning: true,
// Base data
@@ -82,7 +75,6 @@ class Activity {
printlog('$Activity:');
printlog(' Settings');
activitySettings.dump();
- globalSettings.dump();
printlog(' State');
printlog(' isRunning: $isRunning');
printlog(' isStarted: $isStarted');
@@ -104,7 +96,6 @@ class Activity {
return <String, dynamic>{
// Settings
'activitySettings': activitySettings.toJson(),
- 'globalSettings': globalSettings.toJson(),
// State
'isRunning': isRunning,
'isStarted': isStarted,
diff --git a/lib/models/settings/settings_activity.dart b/lib/models/settings/settings_activity.dart
deleted file mode 100644
index fe5cb8c..0000000
--- a/lib/models/settings/settings_activity.dart
+++ /dev/null
@@ -1,59 +0,0 @@
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/config/default_activity_settings.dart';
-
-class ActivitySettings {
- final String itemsCount;
- final String timerValue;
-
- ActivitySettings({
- required this.itemsCount,
- required this.timerValue,
- });
-
- // Getters to convert String to int
- int get itemsCountValue => int.parse(itemsCount);
- int get timerCountValue => int.parse(timerValue);
-
- static String getItemsCountValueFromUnsafe(String itemsCount) {
- if (DefaultActivitySettings.allowedGameModeValues.contains(itemsCount)) {
- return itemsCount;
- }
-
- return DefaultActivitySettings.defaultGameModeValue;
- }
-
- static String getTimerValueFromUnsafe(String timerValue) {
- if (DefaultActivitySettings.allowedDifficultyLevelValues.contains(timerValue)) {
- return timerValue;
- }
-
- return DefaultActivitySettings.difficultyLevelValue;
- }
-
- factory ActivitySettings.createDefault() {
- return ActivitySettings(
- itemsCount: DefaultActivitySettings.defaultGameModeValue,
- timerValue: DefaultActivitySettings.difficultyLevelValue,
- );
- }
-
- void dump() {
- printlog('$ActivitySettings:');
- printlog(' ${DefaultActivitySettings.parameterCodeGameMode}: $itemsCount');
- printlog(' ${DefaultActivitySettings.parameterCodeDifficultyLevel}: $timerValue');
- printlog('');
- }
-
- @override
- String toString() {
- return '$ActivitySettings(${toJson()})';
- }
-
- Map<String, dynamic>? toJson() {
- return <String, dynamic>{
- DefaultActivitySettings.parameterCodeGameMode: itemsCount,
- DefaultActivitySettings.parameterCodeDifficultyLevel: timerValue,
- };
- }
-}
diff --git a/lib/models/settings/settings_global.dart b/lib/models/settings/settings_global.dart
deleted file mode 100644
index 6aaf5c6..0000000
--- a/lib/models/settings/settings_global.dart
+++ /dev/null
@@ -1,42 +0,0 @@
-import 'package:flutter_custom_toolbox/flutter_toolbox.dart';
-
-import 'package:reversi/config/default_global_settings.dart';
-
-class GlobalSettings {
- String skin;
-
- GlobalSettings({
- required this.skin,
- });
-
- static String getSkinValueFromUnsafe(String skin) {
- if (DefaultGlobalSettings.allowedSkinValues.contains(skin)) {
- return skin;
- }
-
- return DefaultGlobalSettings.defaultSkinValue;
- }
-
- factory GlobalSettings.createDefault() {
- return GlobalSettings(
- skin: DefaultGlobalSettings.defaultSkinValue,
- );
- }
-
- void dump() {
- printlog('$GlobalSettings:');
- printlog(' ${DefaultGlobalSettings.parameterCodeSkin}: $skin');
- printlog('');
- }
-
- @override
- String toString() {
- return '$GlobalSettings(${toJson()})';
- }
-
- Map<String, dynamic>? toJson() {
- return <String, dynamic>{
- DefaultGlobalSettings.parameterCodeSkin: skin,
- };
- }
-}
diff --git a/lib/common/ui/pages/game.dart b/lib/ui/pages/game.dart
similarity index 100%
rename from lib/common/ui/pages/game.dart
rename to lib/ui/pages/game.dart
diff --git a/lib/ui/widgets/game/game_board_display.dart b/lib/ui/widgets/game/game_board_display.dart
index ef4417c..0c0785a 100644
--- a/lib/ui/widgets/game/game_board_display.dart
+++ b/lib/ui/widgets/game/game_board_display.dart
@@ -1,8 +1,8 @@
import 'package:flutter/material.dart';
+import 'package:reversi/config/styling.dart';
import 'package:reversi/models/activity/game_board.dart';
import 'package:reversi/models/activity/game_model.dart';
-import 'package:reversi/config/styling.dart';
class GameBoardDisplay extends StatelessWidget {
const GameBoardDisplay({
diff --git a/lib/ui/widgets/game/score_box.dart b/lib/ui/widgets/game/score_box.dart
index cb90ab5..b2d5432 100644
--- a/lib/ui/widgets/game/score_box.dart
+++ b/lib/ui/widgets/game/score_box.dart
@@ -1,8 +1,8 @@
import 'package:flutter/material.dart';
+import 'package:reversi/config/styling.dart';
import 'package:reversi/models/activity/game_board.dart';
import 'package:reversi/models/activity/game_model.dart';
-import 'package:reversi/config/styling.dart';
class ScoreBox extends StatelessWidget {
const ScoreBox({
diff --git a/pubspec.lock b/pubspec.lock
index 0fb7283..d2613fa 100644
--- a/pubspec.lock
+++ b/pubspec.lock
@@ -122,11 +122,11 @@ packages:
dependency: "direct main"
description:
path: "."
- ref: "0.4.0"
- resolved-ref: eb9c090bd00d73324eab8737f74b3339cc24c9e8
+ ref: "0.5.0"
+ resolved-ref: b8164a50489ba981ea57d9f02e2334f09cb8c6a7
url: "https://git.harrault.fr/android/flutter-toolbox.git"
source: git
- version: "0.4.0"
+ version: "0.5.0"
flutter_lints:
dependency: "direct dev"
description:
diff --git a/pubspec.yaml b/pubspec.yaml
index 91db0d2..8b8bb5d 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -3,7 +3,7 @@ description: A reversi game application.
publish_to: "none"
-version: 0.3.2+25
+version: 0.4.0+26
environment:
sdk: "^3.0.0"
@@ -16,7 +16,7 @@ dependencies:
flutter_custom_toolbox:
git:
url: https://git.harrault.fr/android/flutter-toolbox.git
- ref: 0.4.0
+ ref: 0.5.0
# specific
async: ^2.11.0
--
GitLab