From ec0d282483ccee1734fc0a7addcbba1949ed1719 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Tue, 27 Feb 2024 17:02:49 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- fastlane/metadata/android/en-US/changelogs/15.txt | 1 + fastlane/metadata/android/fr-FR/changelogs/15.txt | 1 + lib/provider/data.dart | 6 ++++-- lib/utils/tools.dart | 7 +++++++ pubspec.lock | 4 ++-- pubspec.yaml | 2 +- 7 files changed, 18 insertions(+), 7 deletions(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/15.txt create mode 100644 fastlane/metadata/android/fr-FR/changelogs/15.txt create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index 81949df..957c40b 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=0.0.14 -app.versionCode=14 +app.versionName=0.0.15 +app.versionCode=15 diff --git a/fastlane/metadata/android/en-US/changelogs/15.txt b/fastlane/metadata/android/en-US/changelogs/15.txt new file mode 100644 index 0000000..52f2179 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/15.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/15.txt b/fastlane/metadata/android/fr-FR/changelogs/15.txt new file mode 100644 index 0000000..8537dac --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/15.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/provider/data.dart b/lib/provider/data.dart index 7136778..1293e1a 100644 --- a/lib/provider/data.dart +++ b/lib/provider/data.dart @@ -1,6 +1,8 @@ import 'package:flutter/foundation.dart'; import 'package:shared_preferences/shared_preferences.dart'; +import 'package:plotter/utils/tools.dart'; + class Data extends ChangeNotifier { // Application settings String _apiHost = ''; @@ -20,7 +22,7 @@ class Data extends ChangeNotifier { } setParameterValue(String parameterCode, String parameterValue) async { - print('set parameter "$parameterCode" to value "$parameterValue"'); + printlog('set parameter "$parameterCode" to value "$parameterValue"'); switch (parameterCode) { case 'apiHost': { @@ -45,7 +47,7 @@ class Data extends ChangeNotifier { String get apiStatus => _apiStatus; void updateApiStatus(String apiStatus) { - print('new API status: $apiStatus'); + printlog('new API status: $apiStatus'); _apiStatus = apiStatus; notifyListeners(); } diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.lock b/pubspec.lock index c876a73..036b3cd 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -159,10 +159,10 @@ packages: dependency: "direct main" description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" shared_preferences: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index fe5c8ff..a05e9a0 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: plotter description: A plotter helper application. publish_to: 'none' -version: 0.0.14+14 +version: 0.0.15+15 environment: sdk: '^3.0.0' -- GitLab