From 30be1b299384b805f762080c2683a3787529b38b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Wed, 28 Feb 2024 16:00:18 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- fastlane/metadata/android/en-US/changelogs/8.txt | 1 + fastlane/metadata/android/fr-FR/changelogs/8.txt | 1 + lib/utils/game_utils.dart | 4 +++- lib/utils/tools.dart | 7 +++++++ pubspec.lock | 4 ++-- pubspec.yaml | 2 +- 7 files changed, 17 insertions(+), 6 deletions(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/8.txt create mode 100644 fastlane/metadata/android/fr-FR/changelogs/8.txt create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index 85b94f8..65eed64 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=0.0.7 -app.versionCode=7 +app.versionName=0.0.8 +app.versionCode=8 diff --git a/fastlane/metadata/android/en-US/changelogs/8.txt b/fastlane/metadata/android/en-US/changelogs/8.txt new file mode 100644 index 0000000..52f2179 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/8.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/8.txt b/fastlane/metadata/android/fr-FR/changelogs/8.txt new file mode 100644 index 0000000..8537dac --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/8.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/utils/game_utils.dart b/lib/utils/game_utils.dart index f617350..e07ec70 100644 --- a/lib/utils/game_utils.dart +++ b/lib/utils/game_utils.dart @@ -1,12 +1,14 @@ import 'package:midisynth/provider/data.dart'; +import 'package:midisynth/utils/tools.dart'; + class GameUtils { static Future<void> quitGame(Data myProvider) async { myProvider.updateGameIsRunning(false); } static Future<void> startNewGame(Data myProvider) async { - print('Starting new game'); + printlog('Starting new game'); myProvider.resetGame(); myProvider.updateGameIsRunning(true); diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.lock b/pubspec.lock index 394474f..6b1fdfe 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -151,10 +151,10 @@ packages: dependency: "direct main" description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" shared_preferences: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 66c0833..416a74a 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: midisynth description: MIDI Synth publish_to: 'none' -version: 0.0.7+7 +version: 0.0.8+8 environment: sdk: '^3.0.0' -- GitLab