From 2ce6e0bab55de306ea73dd8681336b97a12a27ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Wed, 28 Feb 2024 22:46:09 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- fastlane/metadata/android/en-US/changelogs/35.txt | 1 + fastlane/metadata/android/fr-FR/changelogs/35.txt | 1 + lib/utils/board_utils.dart | 13 +++++++------ lib/utils/game_utils.dart | 9 +++++---- lib/utils/tools.dart | 7 +++++++ pubspec.lock | 4 ++-- pubspec.yaml | 2 +- 8 files changed, 26 insertions(+), 15 deletions(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/35.txt create mode 100644 fastlane/metadata/android/fr-FR/changelogs/35.txt create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index 4617f96..32638a3 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=0.0.34 -app.versionCode=34 +app.versionName=0.0.35 +app.versionCode=35 diff --git a/fastlane/metadata/android/en-US/changelogs/35.txt b/fastlane/metadata/android/en-US/changelogs/35.txt new file mode 100644 index 0000000..52f2179 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/35.txt @@ -0,0 +1 @@ +Avoid print calls in production code. diff --git a/fastlane/metadata/android/fr-FR/changelogs/35.txt b/fastlane/metadata/android/fr-FR/changelogs/35.txt new file mode 100644 index 0000000..8537dac --- /dev/null +++ b/fastlane/metadata/android/fr-FR/changelogs/35.txt @@ -0,0 +1 @@ +Supprime les appels à print dans le code de production. diff --git a/lib/utils/board_utils.dart b/lib/utils/board_utils.dart index 8e8f31b..86b5dbc 100644 --- a/lib/utils/board_utils.dart +++ b/lib/utils/board_utils.dart @@ -3,21 +3,22 @@ import 'dart:async'; import 'package:colors/entities/cell.dart'; import 'package:colors/provider/data.dart'; +import 'package:colors/utils/tools.dart'; class BoardUtils { static printGrid(List cells) { String stringValues = '012345678'; - print(''); - print('-------'); + printlog(''); + printlog('-------'); for (var rowIndex = 0; rowIndex < cells.length; rowIndex++) { String row = ''; for (var colIndex = 0; colIndex < cells[rowIndex].length; colIndex++) { row += stringValues[cells[rowIndex][colIndex].value]; } - print(row); + printlog(row); } - print('-------'); - print(''); + printlog('-------'); + printlog(''); } static createNewBoard(Data myProvider) { @@ -160,7 +161,7 @@ class BoardUtils { } } - print('-> ok grid solved!'); + printlog('-> ok grid solved!'); return true; } diff --git a/lib/utils/game_utils.dart b/lib/utils/game_utils.dart index 56fee2a..699b199 100644 --- a/lib/utils/game_utils.dart +++ b/lib/utils/game_utils.dart @@ -1,5 +1,6 @@ import 'package:colors/provider/data.dart'; import 'package:colors/utils/board_utils.dart'; +import 'package:colors/utils/tools.dart'; class GameUtils { static Future<void> resetGame(Data myProvider) async { @@ -7,10 +8,10 @@ class GameUtils { } static Future<void> startGame(Data myProvider) async { - print('Starting game'); - print('- level: ${myProvider.parameterLevel}'); - print('- size: ${myProvider.boardSize}'); - print('- colors: ${myProvider.colorsCount}'); + printlog('Starting game'); + printlog('- level: ${myProvider.parameterLevel}'); + printlog('- size: ${myProvider.boardSize}'); + printlog('- colors: ${myProvider.colorsCount}'); BoardUtils.createNewBoard(myProvider); diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/pubspec.lock b/pubspec.lock index 394474f..6b1fdfe 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -151,10 +151,10 @@ packages: dependency: "direct main" description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" shared_preferences: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 927e2e3..d74d30e 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: colors description: colors application publish_to: 'none' -version: 0.0.34+34 +version: 0.0.35+35 environment: sdk: '^3.0.0' -- GitLab