From 82e6a1412e44d89464a087c0f526195e68feea42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr>
Date: Wed, 28 Feb 2024 15:16:51 +0100
Subject: [PATCH] Avoid print calls in production code
---
android/gradle.properties | 4 ++--
fastlane/metadata/android/en-US/changelogs/11.txt | 1 +
fastlane/metadata/android/fr-FR/changelogs/11.txt | 1 +
lib/layout/game.dart | 4 ++--
lib/layout/parameters.dart | 4 ++--
lib/main.dart | 4 ++--
lib/screens/home.dart | 8 ++++----
lib/utils/game_utils.dart | 9 ++++-----
lib/utils/tools.dart | 7 +++++++
pubspec.lock | 4 ++--
pubspec.yaml | 2 +-
11 files changed, 28 insertions(+), 20 deletions(-)
create mode 100644 fastlane/metadata/android/en-US/changelogs/11.txt
create mode 100644 fastlane/metadata/android/fr-FR/changelogs/11.txt
create mode 100644 lib/utils/tools.dart
diff --git a/android/gradle.properties b/android/gradle.properties
index 6bf54a6..f0be9fb 100644
--- a/android/gradle.properties
+++ b/android/gradle.properties
@@ -1,5 +1,5 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
-app.versionName=0.0.10
-app.versionCode=10
+app.versionName=0.0.11
+app.versionCode=11
diff --git a/fastlane/metadata/android/en-US/changelogs/11.txt b/fastlane/metadata/android/en-US/changelogs/11.txt
new file mode 100644
index 0000000..52f2179
--- /dev/null
+++ b/fastlane/metadata/android/en-US/changelogs/11.txt
@@ -0,0 +1 @@
+Avoid print calls in production code.
diff --git a/fastlane/metadata/android/fr-FR/changelogs/11.txt b/fastlane/metadata/android/fr-FR/changelogs/11.txt
new file mode 100644
index 0000000..8537dac
--- /dev/null
+++ b/fastlane/metadata/android/fr-FR/changelogs/11.txt
@@ -0,0 +1 @@
+Supprime les appels à print dans le code de production.
diff --git a/lib/layout/game.dart b/lib/layout/game.dart
index 7ca7d7b..80f46a2 100644
--- a/lib/layout/game.dart
+++ b/lib/layout/game.dart
@@ -1,7 +1,7 @@
import 'package:flutter/material.dart';
-import '../provider/data.dart';
-import '../utils/game_utils.dart';
+import 'package:calculus/provider/data.dart';
+import 'package:calculus/utils/game_utils.dart';
class Game {
static Widget buildGameWidget(Data myProvider) {
diff --git a/lib/layout/parameters.dart b/lib/layout/parameters.dart
index ab21978..5e888e6 100644
--- a/lib/layout/parameters.dart
+++ b/lib/layout/parameters.dart
@@ -1,7 +1,7 @@
import 'package:flutter/material.dart';
-import '../provider/data.dart';
-import '../utils/game_utils.dart';
+import 'package:calculus/provider/data.dart';
+import 'package:calculus/utils/game_utils.dart';
class Parameters {
static Widget buildParametersSelector(Data myProvider) {
diff --git a/lib/main.dart b/lib/main.dart
index f6256a8..7730c76 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -3,8 +3,8 @@ import 'package:flutter/services.dart';
import 'package:provider/provider.dart';
import 'package:overlay_support/overlay_support.dart';
-import 'provider/data.dart';
-import 'screens/home.dart';
+import 'package:calculus/provider/data.dart';
+import 'package:calculus/screens/home.dart';
void main() {
WidgetsFlutterBinding.ensureInitialized();
diff --git a/lib/screens/home.dart b/lib/screens/home.dart
index 5f6d8f1..b114f6f 100644
--- a/lib/screens/home.dart
+++ b/lib/screens/home.dart
@@ -2,10 +2,10 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart';
import 'package:overlay_support/overlay_support.dart';
-import '../layout/game.dart';
-import '../layout/parameters.dart';
-import '../provider/data.dart';
-import '../utils/game_utils.dart';
+import 'package:calculus/layout/game.dart';
+import 'package:calculus/layout/parameters.dart';
+import 'package:calculus/provider/data.dart';
+import 'package:calculus/utils/game_utils.dart';
class Home extends StatefulWidget {
const Home({super.key});
diff --git a/lib/utils/game_utils.dart b/lib/utils/game_utils.dart
index c511d53..745c117 100644
--- a/lib/utils/game_utils.dart
+++ b/lib/utils/game_utils.dart
@@ -1,18 +1,17 @@
-import '../provider/data.dart';
+import 'package:calculus/provider/data.dart';
+import 'package:calculus/utils/tools.dart';
class GameUtils {
-
static Future<void> resetGame(Data myProvider) async {
myProvider.updateGameIsRunning(false);
}
static Future<void> startGame(Data myProvider) async {
- print('Starting game');
- print('- level: ${myProvider.parameterLevel}');
+ printlog('Starting game');
+ printlog('- level: ${myProvider.parameterLevel}');
myProvider.resetGame();
myProvider.updateGameIsRunning(true);
}
-
}
diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart
new file mode 100644
index 0000000..fd48b2b
--- /dev/null
+++ b/lib/utils/tools.dart
@@ -0,0 +1,7 @@
+import 'package:flutter/foundation.dart';
+
+void printlog(String message) {
+ if (!kReleaseMode) {
+ debugPrint(message);
+ }
+}
diff --git a/pubspec.lock b/pubspec.lock
index 394474f..6b1fdfe 100644
--- a/pubspec.lock
+++ b/pubspec.lock
@@ -151,10 +151,10 @@ packages:
dependency: "direct main"
description:
name: provider
- sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096"
+ sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c
url: "https://pub.dev"
source: hosted
- version: "6.1.1"
+ version: "6.1.2"
shared_preferences:
dependency: "direct main"
description:
diff --git a/pubspec.yaml b/pubspec.yaml
index 017bc75..94aa3d1 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,7 +1,7 @@
name: calculus
description: calculus application
publish_to: 'none'
-version: 0.0.10+10
+version: 0.0.11+11
environment:
sdk: '^3.0.0'
--
GitLab