From 33a97e99247d29bafeb6338313034fa0fca30b8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr>
Date: Wed, 28 Feb 2024 15:21:36 +0100
Subject: [PATCH] Avoid print calls in production code
---
android/gradle.properties | 4 ++--
.../metadata/android/en-US/changelogs/20.txt | 1 +
.../metadata/android/fr-FR/changelogs/20.txt | 1 +
lib/main.dart | 21 ++++++++++---------
lib/utils/tools.dart | 7 +++++++
pubspec.yaml | 2 +-
6 files changed, 23 insertions(+), 13 deletions(-)
create mode 100644 fastlane/metadata/android/en-US/changelogs/20.txt
create mode 100644 fastlane/metadata/android/fr-FR/changelogs/20.txt
create mode 100644 lib/utils/tools.dart
diff --git a/android/gradle.properties b/android/gradle.properties
index 53f7ea2..6d853d4 100644
--- a/android/gradle.properties
+++ b/android/gradle.properties
@@ -1,5 +1,5 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
-app.versionName=1.0.18
-app.versionCode=19
+app.versionName=1.0.19
+app.versionCode=20
diff --git a/fastlane/metadata/android/en-US/changelogs/20.txt b/fastlane/metadata/android/en-US/changelogs/20.txt
new file mode 100644
index 0000000..52f2179
--- /dev/null
+++ b/fastlane/metadata/android/en-US/changelogs/20.txt
@@ -0,0 +1 @@
+Avoid print calls in production code.
diff --git a/fastlane/metadata/android/fr-FR/changelogs/20.txt b/fastlane/metadata/android/fr-FR/changelogs/20.txt
new file mode 100644
index 0000000..8537dac
--- /dev/null
+++ b/fastlane/metadata/android/fr-FR/changelogs/20.txt
@@ -0,0 +1 @@
+Supprime les appels à print dans le code de production.
diff --git a/lib/main.dart b/lib/main.dart
index 6a22dde..bc961b3 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -4,6 +4,7 @@ import 'package:flutter/material.dart';
import 'package:memory/data/data.dart';
import 'package:memory/models/tile_model.dart';
+import 'package:memory/utils/tools.dart';
void main() => runApp(const MyApp());
@@ -168,17 +169,17 @@ class TileState extends State<Tile> {
if (selectedTile != "") {
/// testing if the selected tiles are same
if (selectedTile == myPairs[widget.tileIndex].getImageAssetPath()) {
- print("add point");
+ printlog("add point");
points = points + 100;
- print("$selectedTile -> ${widget.imagePathUrl}");
+ printlog("$selectedTile -> ${widget.imagePathUrl}");
TileModel tileModel = TileModel();
- print(widget.tileIndex);
+ printlog(widget.tileIndex.toString());
selected = true;
Future.delayed(const Duration(seconds: 2), () {
tileModel.setImageAssetPath("");
myPairs[widget.tileIndex] = tileModel;
- print(selectedIndex);
+ printlog(selectedIndex.toString());
myPairs[selectedIndex] = tileModel;
widget.parent?.setState(() {});
setState(() {
@@ -187,10 +188,10 @@ class TileState extends State<Tile> {
selectedTile = "";
});
} else {
- print("$selectedTile -> ${myPairs[widget.tileIndex].getImageAssetPath()}");
- print("wrong choice");
- print(widget.tileIndex);
- print(selectedIndex);
+ printlog("$selectedTile -> ${myPairs[widget.tileIndex].getImageAssetPath()}");
+ printlog("wrong choice");
+ printlog(widget.tileIndex.toString());
+ printlog(selectedIndex.toString());
selected = true;
Future.delayed(const Duration(seconds: 2), () {
widget.parent?.setState(() {
@@ -210,8 +211,8 @@ class TileState extends State<Tile> {
selectedIndex = widget.tileIndex;
});
- print(selectedTile);
- print(selectedIndex);
+ printlog(selectedTile);
+ printlog(selectedIndex.toString());
}
}
},
diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart
new file mode 100644
index 0000000..fd48b2b
--- /dev/null
+++ b/lib/utils/tools.dart
@@ -0,0 +1,7 @@
+import 'package:flutter/foundation.dart';
+
+void printlog(String message) {
+ if (!kReleaseMode) {
+ debugPrint(message);
+ }
+}
diff --git a/pubspec.yaml b/pubspec.yaml
index dc1240e..1ac31dc 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,7 +1,7 @@
name: memory
description: A simple and classic memory game.
publish_to: 'none'
-version: 1.0.18+19
+version: 1.0.19+20
environment:
sdk: '^3.0.0'
--
GitLab