From 48381f4007dd9278b2742c23b9b3a8867ca33ee8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Harrault?= <benoit@harrault.fr> Date: Tue, 27 Feb 2024 17:01:20 +0100 Subject: [PATCH] Avoid print calls in production code --- android/gradle.properties | 4 ++-- lib/main.dart | 10 +++++----- lib/provider/data.dart | 4 ++-- lib/screens/game.dart | 8 ++++---- lib/screens/home.dart | 10 +++++----- lib/screens/scores.dart | 4 ++-- lib/utils/random_pick.dart | 11 ++++++----- lib/utils/tools.dart | 7 +++++++ lib/widgets/dialog_gameover.dart | 8 ++++---- lib/widgets/letters.dart | 6 +++--- lib/widgets/my_app_bar.dart | 2 +- pubspec.lock | 4 ++-- pubspec.yaml | 2 +- 13 files changed, 44 insertions(+), 36 deletions(-) create mode 100644 lib/utils/tools.dart diff --git a/android/gradle.properties b/android/gradle.properties index dfa1e9f..285f43a 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -1,5 +1,5 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -app.versionName=1.2.13 -app.versionCode=24 +app.versionName=1.2.14 +app.versionCode=25 diff --git a/lib/main.dart b/lib/main.dart index 99fcffa..a96452b 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -1,11 +1,11 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import 'provider/data.dart'; -import 'screens/home.dart'; -import 'screens/game.dart'; -import 'screens/scores.dart'; -import 'utils/constants.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/screens/game.dart'; +import 'package:hangman/screens/home.dart'; +import 'package:hangman/screens/scores.dart'; +import 'package:hangman/utils/constants.dart'; void main() => runApp(const Hangman()); diff --git a/lib/provider/data.dart b/lib/provider/data.dart index 6da7610..1bbdf06 100644 --- a/lib/provider/data.dart +++ b/lib/provider/data.dart @@ -1,7 +1,7 @@ import 'package:flutter/foundation.dart'; -import '../utils/shared_prefs.dart'; -import '../utils/constants.dart'; +import 'package:hangman/utils/constants.dart'; +import 'package:hangman/utils/shared_prefs.dart'; class Data extends ChangeNotifier { // settings diff --git a/lib/screens/game.dart b/lib/screens/game.dart index 1305fc1..65f2f42 100644 --- a/lib/screens/game.dart +++ b/lib/screens/game.dart @@ -1,10 +1,10 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import '../provider/data.dart'; -import '../utils/constants.dart'; -import '../utils/random_pick.dart'; -import '../widgets/letters.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/utils/constants.dart'; +import 'package:hangman/utils/random_pick.dart'; +import 'package:hangman/widgets/letters.dart'; class Game extends StatelessWidget { const Game({super.key}); diff --git a/lib/screens/home.dart b/lib/screens/home.dart index b17a520..4a797a7 100644 --- a/lib/screens/home.dart +++ b/lib/screens/home.dart @@ -1,11 +1,11 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import '../provider/data.dart'; -import 'game.dart'; -import '../widgets/my_app_bar.dart'; -import '../widgets/dialog_fetch_error.dart'; -import '../utils/constants.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/screens/game.dart'; +import 'package:hangman/utils/constants.dart'; +import 'package:hangman/widgets/dialog_fetch_error.dart'; +import 'package:hangman/widgets/my_app_bar.dart'; class Home extends StatelessWidget { const Home({super.key}); diff --git a/lib/screens/scores.dart b/lib/screens/scores.dart index f1e62fe..2a26025 100644 --- a/lib/screens/scores.dart +++ b/lib/screens/scores.dart @@ -1,8 +1,8 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import '../provider/data.dart'; -import '../utils/constants.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/utils/constants.dart'; class Scores extends StatelessWidget { const Scores({super.key}); diff --git a/lib/utils/random_pick.dart b/lib/utils/random_pick.dart index 08d4446..668d5be 100644 --- a/lib/utils/random_pick.dart +++ b/lib/utils/random_pick.dart @@ -1,13 +1,14 @@ import 'dart:async'; -import 'package:html/parser.dart'; -import 'package:html/dom.dart'; -import 'package:http/http.dart' as http; import 'dart:convert'; -import 'package:flutter/services.dart'; import 'dart:math' show Random; + import 'package:diacritic/diacritic.dart'; +import 'package:flutter/services.dart'; +import 'package:html/parser.dart'; +import 'package:html/dom.dart'; +import 'package:http/http.dart' as http; -import '../words/list_french_words.dart'; +import 'package:hangman/words/list_french_words.dart'; class RandomPick { final String level; diff --git a/lib/utils/tools.dart b/lib/utils/tools.dart new file mode 100644 index 0000000..fd48b2b --- /dev/null +++ b/lib/utils/tools.dart @@ -0,0 +1,7 @@ +import 'package:flutter/foundation.dart'; + +void printlog(String message) { + if (!kReleaseMode) { + debugPrint(message); + } +} diff --git a/lib/widgets/dialog_gameover.dart b/lib/widgets/dialog_gameover.dart index af0a6cc..512c094 100644 --- a/lib/widgets/dialog_gameover.dart +++ b/lib/widgets/dialog_gameover.dart @@ -1,10 +1,10 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import '../screens/home.dart'; -import '../screens/game.dart'; -import '../provider/data.dart'; -import '../utils/constants.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/screens/game.dart'; +import 'package:hangman/screens/home.dart'; +import 'package:hangman/utils/constants.dart'; class DialogGameOver extends StatelessWidget { final GameOver gameOver; diff --git a/lib/widgets/letters.dart b/lib/widgets/letters.dart index 6993850..2c13855 100644 --- a/lib/widgets/letters.dart +++ b/lib/widgets/letters.dart @@ -1,9 +1,9 @@ import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; -import '../provider/data.dart'; -import '../utils/constants.dart'; -import '../widgets/dialog_gameover.dart'; +import 'package:hangman/provider/data.dart'; +import 'package:hangman/utils/constants.dart'; +import 'package:hangman/widgets/dialog_gameover.dart'; class LetterButtons extends StatelessWidget { const LetterButtons({super.key}); diff --git a/lib/widgets/my_app_bar.dart b/lib/widgets/my_app_bar.dart index 230a492..d25c46f 100644 --- a/lib/widgets/my_app_bar.dart +++ b/lib/widgets/my_app_bar.dart @@ -1,7 +1,7 @@ import 'package:flutter/material.dart'; import 'package:flutter/services.dart' show SystemNavigator; -import '../screens/scores.dart'; +import 'package:hangman/screens/scores.dart'; class MyAppBar extends StatelessWidget implements PreferredSizeWidget { const MyAppBar({super.key, this.appBar}); diff --git a/pubspec.lock b/pubspec.lock index e2b0f4c..2599bd0 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -183,10 +183,10 @@ packages: dependency: "direct main" description: name: provider - sha256: "9a96a0a19b594dbc5bf0f1f27d2bc67d5f95957359b461cd9feb44ed6ae75096" + sha256: c8a055ee5ce3fd98d6fc872478b03823ffdb448699c6ebdbbc71d59b596fd48c url: "https://pub.dev" source: hosted - version: "6.1.1" + version: "6.1.2" shared_preferences: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 00a9529..15041ac 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: hangman description: Hangman game, have fun with words and letters! publish_to: 'none' -version: 1.2.13+24 +version: 1.2.14+25 environment: sdk: '^3.0.0' -- GitLab